Skip to content

Commit 7b9d0a9

Browse files
committed
save the view before attempting to edit
1 parent 1c0d238 commit 7b9d0a9

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

src/org/labkey/test/tests/component/GridPanelViewTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.labkey.test.util.SampleTypeHelper;
3030
import org.labkey.test.util.TestDataGenerator;
3131
import org.labkey.test.util.exp.SampleTypeAPIHelper;
32+
import org.openqa.selenium.TimeoutException;
3233
import org.openqa.selenium.WebDriverException;
3334

3435
import java.io.IOException;
@@ -40,6 +41,8 @@
4041
import java.util.List;
4142
import java.util.Map;
4243

44+
import static org.junit.Assert.fail;
45+
4346
@Category({Daily.class})
4447
public class GridPanelViewTest extends GridPanelBaseTest
4548
{
@@ -1292,18 +1295,23 @@ public void testWarningOnInvalidDateFilter()
12921295
.hasSize(1)
12931296
.filteredOn(a-> a.getText().equals("Created > 2024-05-27"))
12941297
.isNotEmpty());
1298+
grid.saveView().saveView();
12951299
grid.clearFilters();
12961300

12971301
log("try to filter on an invalid date");
12981302
grid.filterColumn("Created", Filter.Operator.GT, new FilterExpressionPanel.DateString("05/37/2024"));
12991303
// don't expect the parser to get the invalid date right; current behavior won't do that
1304+
// also add a bogus filter on int column, verify it refuses to do it
1305+
var err = grid.filterColumnExpectingError("Int", Filter.Operator.GT, "XYZ");
1306+
checker().verifyEquals("expect error when trying to configure invalid filter",
1307+
"Missing filter values for: Int.", err);
1308+
grid.saveView().saveView();
13001309

13011310
log("ensure the view can be edited after");
13021311
grid.filterColumn("Created", Filter.Operator.LTE, new Date()); // filter on right now
13031312

1304-
grid.clickUndoButton(); // undo will clear the view from its edited state, make it deletable
13051313
grid.manageViews() // ensure the view can be deleted now
1306-
.deleteViewAndConfirm(viewName + " (shared)")
1314+
.deleteViewAndConfirm(viewName)
13071315
.dismiss("Done");
13081316
}
13091317

0 commit comments

Comments
 (0)