Skip to content

Commit 877a253

Browse files
committed
Test fixes for change from quoted values to bold in error messages
1 parent f3a7ed5 commit 877a253

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

src/org/labkey/test/LabKeySiteWrapper.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1721,23 +1721,28 @@ protected void deletePipelineJob(@LoggedParam String jobDescription, @LoggedPara
17211721

17221722
public String getConversionErrorMessage(Object value, String fieldName, Class<?> targetClass)
17231723
{
1724-
return getConversionErrorMessage(value, fieldName, targetClass, true);
1724+
return getConversionErrorMessage(value, fieldName, targetClass, true, false);
17251725
}
17261726

17271727
// Note: Keep in sync with ConvertHelper.getStandardConversionErrorMessage()
17281728
// Example: "Could not convert value '2.34' (Double) for Boolean field 'Medical History.Dep Diagnosed in Last 18 Months'"
1729-
public String getConversionErrorMessage(Object value, String fieldName, Class<?> targetClass, boolean useUSDateParsing)
1729+
public String getConversionErrorMessage(Object value, String fieldName, Class<?> targetClass, boolean useUSDateParsing, boolean removeSingleQuotes)
17301730
{
1731+
String errorMessage;
17311732
String fieldType = targetClass.getSimpleName();
17321733

17331734
// Issue 50768: Need a better error message if date value is not in the expected format.
17341735
if (fieldType.equalsIgnoreCase("date") || fieldType.equalsIgnoreCase("datetime") || fieldType.equalsIgnoreCase("timestamp"))
17351736
{
17361737
String parsingMode = useUSDateParsing ? "U.S. date parsing (MDY)" : "Non-U.S. date parsing (DMY)";
1737-
return value + " is not a valid " + fieldType + " for " + fieldName + " using " + parsingMode;
1738+
errorMessage = "'" + value + "' is not a valid " + fieldType + " for " + fieldName + " using " + parsingMode;
1739+
}
1740+
else
1741+
{
1742+
errorMessage = "Could not convert value '" + value + "' (" + value.getClass().getSimpleName() + ") for " + fieldType + " field '" + fieldName + "'";
17381743
}
17391744

1740-
return "Could not convert value " + value + " (" + value.getClass().getSimpleName() + ") for " + fieldType + " field " + fieldName;
1745+
return removeSingleQuotes ? errorMessage.replace("'", "") : errorMessage;
17411746
}
17421747

17431748
private ProductKey getProductConfiguration() throws IOException, CommandException

0 commit comments

Comments
 (0)