Skip to content

Commit 8ba8b85

Browse files
authored
Move study design features into a new module (#2459)
1 parent 405aeb2 commit 8ba8b85

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

src/org/labkey/test/tests/AdvancedImportOptionsTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ public class AdvancedImportOptionsTest extends BaseWebDriverTest implements Post
7171
private static final boolean EXPECTED_IMPORT_ERRORS = false;
7272
private static final int EXPECTED_COMPLETED_IMPORT_JOBS = 1;
7373
private static final int EXPECTED_COMPLETED_MULTI_FOLDER_JOBS = 2;
74-
private Boolean _studyDesignPreviouslyEnabled;
7574
private Boolean _advancedImportOptionsEnabled;
7675

7776
@Override
@@ -96,7 +95,6 @@ protected BrowserType bestBrowser()
9695
public static void doSetup()
9796
{
9897
AdvancedImportOptionsTest test = getCurrentTest();
99-
test._studyDesignPreviouslyEnabled = OptionalFeatureHelper.enableOptionalFeature(test.createDefaultConnection(), "studyDesignFlag");
10098
test._advancedImportOptionsEnabled = OptionalFeatureHelper.enableOptionalFeature(test.createDefaultConnection(), "advancedImportFlag");
10199
}
102100

@@ -108,8 +106,6 @@ public void doCleanup(boolean afterTest) throws TestTimeoutException
108106
_containerHelper.deleteProject(IMPORT_PROJECT_FILE02, false);
109107
_containerHelper.deleteProject(IMPORT_PROJECT_FILE03, false);
110108
_containerHelper.deleteProject(IMPORT_PROJECT_MULTI, false);
111-
if (_studyDesignPreviouslyEnabled != null)
112-
OptionalFeatureHelper.setOptionalFeature(createDefaultConnection(), "studyDesignFlag", _studyDesignPreviouslyEnabled);
113109

114110
if (_advancedImportOptionsEnabled != null)
115111
OptionalFeatureHelper.setOptionalFeature(createDefaultConnection(), "advancedImportFlag", _advancedImportOptionsEnabled);

src/org/labkey/test/util/StudyHelper.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -561,15 +561,18 @@ public void setupRepositoryType(boolean advanced, boolean editable, boolean requ
561561
public boolean isSpecimenModulePresent()
562562
{
563563
if (null == _specimenModulePresent)
564-
{
565-
AbstractContainerHelper containerHelper = new APIContainerHelper(_test);
566-
Set<String> allModules = containerHelper.getAllModules();
567-
_specimenModulePresent = allModules.contains("specimen");
568-
}
564+
_specimenModulePresent = isModulePresent("specimen");
569565

570566
return _specimenModulePresent;
571567
}
572568

569+
public boolean isModulePresent(String moduleName)
570+
{
571+
AbstractContainerHelper containerHelper = new APIContainerHelper(_test);
572+
Set<String> allModules = containerHelper.getAllModules();
573+
return allModules.contains(moduleName);
574+
}
575+
573576
public boolean isSpecimenModuleActive()
574577
{
575578
if (!isSpecimenModulePresent())

0 commit comments

Comments
 (0)