Implementing code review feedback from claude.

Author: labkey-danield

src/org/labkey/test/TestFileUtils.java

@@ -451,30 +451,21 @@ public static void deleteDir(File dir)
      * @param sourceDir the directory to rename
      * @param newDirName the new name for the directory
      */
-    public static void renameDir(Path sourceDir, String newDirName)
+    public static void renameDir(Path sourceDir, String newDirName) throws IOException
     {
         LOG.info("Renaming {} to {}", sourceDir, newDirName);
 
         // Check if the directory is outside the test enlistment.
         checkFileLocation(sourceDir.toFile());
 
-        Assert.assertTrue(sourceDir + " does not exists.", sourceDir.toFile().exists());
+        Assert.assertTrue("Directory does not exist: " + sourceDir, sourceDir.toFile().exists());
 
-        try
-        {
-            // Get the separator appropriate for the given OS.
-            String separator = File.separator;
-            int lastIndex = sourceDir.toString().lastIndexOf(separator);
-            Path newDir = lastIndex <= 0 ?
-                    Paths.get(separator + newDirName) :
-                    Paths.get(sourceDir.toString().substring(0, lastIndex) + separator + newDirName);
-            Files.move(sourceDir, newDir);
-            LOG.info("Rename successful.");
-        }
-        catch (IOException e)
-        {
-            LOG.info("WARNING: Exception renaming directory -- " + e.getMessage());
-        }
+        Path newDir = sourceDir.getParent() != null
+                ? sourceDir.getParent().resolve(newDirName)
+                : Paths.get(newDirName);
+        Files.move(sourceDir, newDir);
+
+        LOG.info("Rename successful.");
     }
 
     private static void checkFileLocation(File file)

src/org/labkey/test/tests/assay/AssayTransformMissingParentDirTest.java

@@ -1,7 +1,6 @@
 package org.labkey.test.tests.assay;
 
 import org.apache.commons.io.FileUtils;
-import org.apache.commons.lang3.SystemUtils;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
@@ -19,8 +18,7 @@
 import java.io.File;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.time.Instant;
+import java.util.UUID;
 
 /**
  * Issue 54156: Regression test to ensure a reasonable error message is shown when an assay design references
@@ -53,7 +51,7 @@ public void testMissingParentDirectoryRegression() throws Exception
 
         // Now rename the parent dir to ensure we handle it reasonably. Deleting directories on Windows is not always
         // timely, renaming the directory will have the same effect.
-        String newName = "Not-Here-" + Instant.now().getEpochSecond();
+        String newName = "Not-Here-" + UUID.randomUUID();
         TestFileUtils.renameDir(parentDir, newName);
 
         Assert.assertFalse(String.format("Directory %s is still present.", parentDir),