Fix some recent/intermittent teamcity test failures (#2389)

Author: labkey-chrisj

src/org/labkey/test/WebDriverWrapper.java

@@ -116,6 +116,7 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.net.URLDecoder;
+import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Paths;
@@ -460,6 +461,7 @@ protected Pair<WebDriver, DriverService> createNewWebDriver(@NotNull Pair<WebDri
         String browserVersion = caps.getBrowserVersion();
         log("Browser: " + browserName + " " + browserVersion);
         log("Started browser with TZ = " + targetBrowserTimeZone + (targetBrowserTimeZone != ZoneId.systemDefault() ? "" : " (system default)"));
+        log(String.format("charset is %s", Charset.defaultCharset().displayName()));
 
         return result;
     }

src/org/labkey/test/pages/assay/RunQCPage.java

@@ -16,6 +16,7 @@
 package org.labkey.test.pages.assay;
 
 import org.labkey.test.Locator;
+import org.labkey.test.WebDriverWrapper;
 import org.labkey.test.components.PlateGrid;
 import org.labkey.test.pages.LabKeyPage;
 import org.labkey.test.selenium.LazyWebElement;
@@ -35,6 +36,14 @@ public RunQCPage(WebDriver driver){
         _driver = driver;
     }
 
+    @Override
+    protected void waitForPage()
+    {
+        Locator waitMsg = Locator.tagWithClass("div", "x4-mask-msg-text").withText("Requesting QC information");
+        WebDriverWrapper.waitFor(()-> !waitMsg.isDisplayed(getDriver()),
+                "Took too long to display the page", WAIT_FOR_JAVASCRIPT);
+    }
+
     public WebElement getSpecimenSection(String sectionTitle)
     {
         String xpath = elementCache().DILUTION_SUMMARY_XPATH + "//tbody//tr//td[text()='" + sectionTitle + "']";
@@ -74,7 +83,7 @@ public void selectPlateItemsToIgnore(String plateTitle, List<String> valuesToIgn
         String xpath = elementCache().PLATE_CONTROLS_VALUES_XPATH.replace("$", plateTitle);
         for(String value : valuesToIgnore)
         {
-            click(Locator.xpath(xpath + "//label[text()='" + value + "']"));
+            waitAndClick(Locator.xpath(xpath + "//label[text()='" + value + "']"));
         }
     }
 
@@ -83,7 +92,7 @@ public void selectDilutionItemsToIgnore(String sectionTitle, List<String> values
         String xpath = elementCache().DILUTION_SUMMARY_VALUES_XPATH.replace("$", sectionTitle);
         for(String value : valuesToIgnore)
         {
-            click(Locator.xpath(xpath + "//label[text()='" + value + "']"));
+            waitAndClick(Locator.xpath(xpath + "//label[text()='" + value + "']"));
         }
     }
 

src/org/labkey/test/tests/SimpleModuleTest.java

@@ -461,7 +461,7 @@ private void submitAndTestExpectedFailure(Command cmd, String expectedError) thr
     @LogMethod
     private void doTestCustomFolder()
     {
-        clickProject(getProjectName());
+        goToProjectHome();
         PortalHelper portalHelper = new PortalHelper(this);
 
         assertTextPresentInThisOrder("A customized web part", "Data Pipeline", "Experiment Runs", "Sample Type", "Assay List");