GitHub Issue 919: Add to Storage > Search for Samples removal of "More Filters" button and related code (#2925)

cnathe · web-flow · commit a12ab932c46b · 2026-03-31T11:08:34.000-05:00
- GridFilterModal finder update to include title prefix
diff --git a/src/org/labkey/test/components/ui/grids/GridFilterModal.java b/src/org/labkey/test/components/ui/grids/GridFilterModal.java
@@ -26,7 +26,12 @@ public class GridFilterModal extends ModalDialog
 
     public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent)
     {
-        super(new ModalDialogFinder(driver));
+        this(driver, linkedComponent, "Filter");
+    }
+
+    public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent, String titlePrefix)
+    {
+        super(new ModalDialogFinder(driver).withTitle(titlePrefix));
         _linkedComponent = linkedComponent;
     }
 
diff --git a/src/org/labkey/test/components/ui/search/EntityFieldFilterModal.java b/src/org/labkey/test/components/ui/search/EntityFieldFilterModal.java
@@ -19,7 +19,7 @@ public class EntityFieldFilterModal extends GridFilterModal
 {
     public EntityFieldFilterModal(WebDriver driver, UpdatingComponent linkedComponent)
     {
-        super(driver, linkedComponent);
+        super(driver, linkedComponent, "Select");
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,12 @@ public class GridFilterModal extends ModalDialog`
`26`	`26`
`27`	`27`	`public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent)`
`28`	`28`	`{`
`29`		`- super(new ModalDialogFinder(driver));`
	`29`	`+ this(driver, linkedComponent, "Filter");`
	`30`	`+ }`
	`31`	`+`
	`32`	`+ public GridFilterModal(WebDriver driver, UpdatingComponent linkedComponent, String titlePrefix)`
	`33`	`+ {`
	`34`	`+ super(new ModalDialogFinder(driver).withTitle(titlePrefix));`
`30`	`35`	`_linkedComponent = linkedComponent;`
`31`	`36`	`}`
`32`	`37`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public class EntityFieldFilterModal extends GridFilterModal`
`19`	`19`	`{`
`20`	`20`	`public EntityFieldFilterModal(WebDriver driver, UpdatingComponent linkedComponent)`
`21`	`21`	`{`
`22`		`- super(driver, linkedComponent);`
	`22`	`+ super(driver, linkedComponent, "Select");`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`@Override`