Apply suggestions from code review

DariaBod · labkey-tchad · web-flow · commit bbd7b3709396 · 2026-03-24T18:00:01.000-07:00
Co-authored-by: Trey Chadick &lt;tchad@labkey.com&gt;
diff --git a/src/org/labkey/test/util/data/TestArrayDataUtils.java b/src/org/labkey/test/util/data/TestArrayDataUtils.java
@@ -60,7 +60,7 @@ public static <T> Map<String, List<String>> filterMap(Map<String, T> map, List<S
     public static List<String> sortValues(List<String> values)
     {
         return values.stream()
-                .filter(s -> !s.isEmpty())
+                .peek(s -> { if (s.isEmpty()) throw new IllegalArgumentException("Empty values aren't allowed: " + values);})
                 .sorted(Comparator
                         .comparing((String s) -> s.substring(0, 1).toLowerCase())
                         .thenComparing(s -> s.substring(0, 1))

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public static <T> Map<String, List<String>> filterMap(Map<String, T> map, List<S`
`60`	`60`	`public static List<String> sortValues(List<String> values)`
`61`	`61`	`{`
`62`	`62`	`return values.stream()`
`63`		`- .filter(s -> !s.isEmpty())`
	`63`	`+ .peek(s -> { if (s.isEmpty()) throw new IllegalArgumentException("Empty values aren't allowed: " + values);})`
`64`	`64`	`.sorted(Comparator`
`65`	`65`	`.comparing((String s) -> s.substring(0, 1).toLowerCase())`
`66`	`66`	`.thenComparing(s -> s.substring(0, 1))`