Skip to content

Commit d461d90

Browse files
committed
fix comments
1 parent 9d0b541 commit d461d90

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

src/org/labkey/test/pages/query/UpdateQueryRowPage.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static UpdateQueryRowPage beginAt(WebDriverWrapper webDriverWrapper, Stri
5555
public static UpdateQueryRowPage beginAtInsertRowPage(WebDriverWrapper webDriverWrapper, String containerPath, String schemaName, String queryName)
5656
{
5757
webDriverWrapper.beginAt(WebTestHelper.buildURL("query", containerPath, "insertQueryRow",
58-
Map.of("schemaName", schemaName, "query.queryName", queryName)));
58+
Map.of("schemaName", schemaName, "query.queryName", queryName)));
5959
return new UpdateQueryRowPage(webDriverWrapper.getDriver());
6060
}
6161

@@ -117,7 +117,7 @@ public UpdateQueryRowPage setField(String fieldName, String value)
117117

118118
public UpdateQueryRowPage setField(String fieldName, List<String> values)
119119
{
120-
Select field = SelectWrapper.Select(Locator.name(EscapeUtil.getFormFieldName(fieldName, true))).find(new ElementCache());
120+
Select field = elementCache().getMultiChoiceSelect(fieldName);
121121
field.deselectAll();
122122
values.forEach(field::selectByVisibleText);
123123
return this;
@@ -151,12 +151,6 @@ public UpdateQueryRowPage setField(String fieldName, OptionSelect.SelectOption o
151151
return this;
152152
}
153153

154-
public UpdateQueryRowPage setMultiValueField(String fieldName, OptionSelect.SelectOption option)
155-
{
156-
new OptionSelect<>(elementCache().findField(fieldName, true)).selectOption(option);
157-
return this;
158-
}
159-
160154
public String getTextInputValue(String fieldName)
161155
{
162156
var input = new Input(elementCache().findField(fieldName), getDriver());
@@ -218,5 +212,11 @@ WebElement findField(String name)
218212
}
219213

220214
final WebElement submitButton = Locator.lkButton("Submit").findWhenNeeded(this);
215+
216+
Select getMultiChoiceSelect(String name)
217+
{
218+
return SelectWrapper.Select(Locator.name(EscapeUtil.getFormFieldName(name, true)))
219+
.find(getDriver());
220+
}
221221
}
222222
}

0 commit comments

Comments
 (0)