Try renaming rather than deleting the directory on Windows.

Author: labkey-danield

src/org/labkey/test/TestFileUtils.java

@@ -38,6 +38,7 @@
 import org.bouncycastle.openpgp.operator.jcajce.JcePBEDataDecryptorFactoryBuilder;
 import org.bouncycastle.util.io.Streams;
 import org.jetbrains.annotations.NotNull;
+import org.junit.Assert;
 import org.labkey.api.util.FileUtil;
 import org.jetbrains.annotations.Nullable;
 import org.openqa.selenium.NotFoundException;
@@ -445,6 +446,25 @@ public static void deleteDir(File dir)
         }
     }
 
+    public static void renameDir(Path sourceDir, String newDirName)
+    {
+        LOG.info("Renaming " + sourceDir + " to " + newDirName);
+        checkFileLocation(sourceDir.toFile());
+        Assert.assertTrue(sourceDir + " does not exists.", sourceDir.toFile().exists());
+
+        try
+        {
+            String separator = File.separator;
+            Path newDir = Paths.get(sourceDir.toString().substring(0, sourceDir.toString().lastIndexOf(separator)) + separator + newDirName);
+            Files.move(sourceDir, newDir);
+            LOG.info("Rename successful.");
+        }
+        catch (IOException e)
+        {
+            LOG.info("WARNING: Exception renaming directory -- " + e.getMessage());
+        }
+    }
+
     private static void checkFileLocation(File file)
     {
         try

src/org/labkey/test/tests/assay/AssayTransformMissingParentDirTest.java

@@ -1,11 +1,11 @@
 package org.labkey.test.tests.assay;
 
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.SystemUtils;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.labkey.api.util.FileUtil;
-import org.labkey.test.BaseWebDriverTest;
 import org.labkey.test.Locator;
 import org.labkey.test.TestFileUtils;
 import org.labkey.test.categories.Assays;
@@ -19,6 +19,8 @@
 import java.io.File;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Instant;
 
 /**
  * Issue 54156: Regression test to ensure a reasonable error message is shown when an assay design references
@@ -49,18 +51,19 @@ public void testMissingParentDirectoryRegression() throws Exception
         getArtifactCollector().dumpPageSnapshot("TransformScript_Added");
         assayDesignerPage.clickSave();
 
-        // Now delete the parent dir to ensure we handle it reasonably
-        TestFileUtils.deleteDir(parentDir.toFile());
-
-        int count = 1;
-        while (!FileUtils.isDirectory(parentDir.toFile()) && count <= 5)
+        // Now delete, or rename, the parent dir to ensure we handle it reasonably
+        if (SystemUtils.IS_OS_WINDOWS)
+        {
+            // Deleting directories on Windows is not always reliable, try renaming as an alternative.
+            String newName = "Not-Here-" + Instant.now().getEpochSecond();
+            TestFileUtils.renameDir(parentDir, newName);
+        }
+        else
         {
-            sleep(1_000);
             TestFileUtils.deleteDir(parentDir.toFile());
-            count++;
         }
 
-        Assert.assertFalse(String.format("Directory %s not deleted.", parentDir.toString()),
+        Assert.assertFalse(String.format("Directory %s is still present.", parentDir),
                 FileUtils.isDirectory(parentDir.toFile()));
 
         // Attempt to import data and verify a reasonable error message is shown