Skip to content

[Frontend] global_ui/Button.tsx is a dead, hardcoded-style duplicate of the design-system ui/Button; its test exercises the unused component #1247

Description

@grantfox-oss

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

frontend/src/app/components/global_ui/Button.tsx is a 336-byte stub with hardcoded px-4 py-2 bg-blue-600 styles, no variants/sizes/loading/forwardRef, and a default export. It is imported by nothing except its own frontend/src/app/components/global_ui/Button.test.tsx - the real, app-wide button is frontend/src/app/components/ui/Button.tsx (named export, 5 variants, used in 6+ files and the ui-demo). The stub shadows the design system and the test gives a false impression that Button is covered when it tests the unused component.

Acceptance criteria

  • Delete frontend/src/app/components/global_ui/Button.tsx and frontend/src/app/components/global_ui/Button.test.tsx (or repoint the test at ui/Button.tsx)
  • Confirm no imports break (grep shows zero non-test references)
  • Ensure remaining button usages go through src/app/components/ui/Button.tsx

Files to touch

  • frontend/src/app/components/global_ui/Button.tsx
  • frontend/src/app/components/global_ui/Button.test.tsx
  • frontend/src/app/components/ui/Button.tsx

Out of scope

  • Refactoring the design-system Button API

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programenhancementNew feature or requestfrontendIssues related to frontend developmentuiUser Interface related issues

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions