[Testing] criticalFlows.spec.ts duplicates the loan-request and repay flows already covered by dedicated specs, with divergent mock shapes that risk drift

[grantfox-oss]

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

frontend/e2e/criticalFlows.spec.ts Flow 1 (loan wizard) overlaps frontend/e2e/borrower-loan-flow.spec.ts and Flow 3 (repay) overlaps frontend/e2e/borrower-repay-flow.spec.ts, but the two sets mock different route shapes (e.g. criticalFlows mocks **/api/loans/123/repay and a flat loans response while borrower-repay-flow mocks its own shapes). Maintaining two divergent copies of the same flow means a UI/contract change must be fixed twice and the specs can silently disagree about the real API.

Acceptance criteria

• Consolidate the loan-request and repay coverage into the dedicated specs (borrower-loan-flow.spec.ts, borrower-repay-flow.spec.ts) and remove the duplicated flows from criticalFlows.spec.ts, or extract a shared mock/fixtures module both reuse
• Ensure the single source uses one consistent set of route mocks
• Keep any criticalFlows-only coverage (e.g. settings/logout) intact

Files to touch

• frontend/e2e/criticalFlows.spec.ts
• frontend/e2e/borrower-loan-flow.spec.ts
• frontend/e2e/borrower-repay-flow.spec.ts

Out of scope

• Rewriting the components under test
• Changing CI runner configuration

[mordabdul1]

Hello, I’m interested in working on this issue and would appreciate being assigned to it. Thank you.

[Jo-anny]

@Jo-anny has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi, I would love to work on this issue.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jo-anny to this issue.

[chinelo002]

@chinelo002 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

hello can i work on this issue?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @chinelo002 to this issue.

[drips-wave]

Congratulations, @chinelo002! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @chinelo002: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @chinelo002 as part of the Stellar Wave Program's 6th Wave 🥳

😎 @chinelo002: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.