Skip to content

[CI] scripts/ package (deploy.ts) is never type-checked or linted in CI, so the on-chain deploy entrypoint can break silently #1255

Description

@grantfox-oss

Telegram (ask questions / claim the issue here first): https://t.me/+DOylgFv1jyJlNzM0

Why this matters

scripts/ is a real TypeScript package (scripts/package.json, scripts/deploy.ts ~290 lines run via ts-node) but no CI job installs it or runs tsc --noEmit on it. ci.yml's env-docs-check only executes scripts/check-env-docs.mjs directly. A type error or stellar-sdk API drift in deploy.ts would only be discovered during an actual mainnet/testnet deploy.

Acceptance criteria

  • A CI job runs npm ci and a typecheck (tsc --noEmit) for the scripts package
  • Job is cached (cache-dependency-path scripts/package-lock.json) consistent with the other Node jobs
  • A deliberate type error in deploy.ts fails the job

Files to touch

  • .github/workflows/ci.yml
  • scripts/package.json
  • scripts/deploy.ts

Out of scope

  • Adding a lint config to scripts/ if none exists (typecheck is sufficient for this issue)
  • Running an actual deploy in CI

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programdevopsIssues related to CI/CD and infrastructuregithub_actionsPull requests that update GitHub Actions code

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions