From 151ef77e9e8cfa7b47da01613775d8c7824612a2 Mon Sep 17 00:00:00 2001 From: juliolmuller Date: Sat, 27 Jun 2026 02:48:59 -0300 Subject: [PATCH] fix(cnpj-dv): adjust error message for CNPJ composition consistency Fix as per @coderabbitai review comment at https://github.com/LacusSolutions/br-utils-py/pull/55#discussion_r3485232221. Co-authored-by: CodeRabbit AI Co-authored-by: Cursor Agent --- packages/cnpj-dv/CHANGELOG.md | 6 ++++++ .../src/Exceptions/CnpjCheckDigitsInputLengthException.php | 2 +- packages/cnpj-dv/tests/specs/Exceptions.spec.php | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/cnpj-dv/CHANGELOG.md b/packages/cnpj-dv/CHANGELOG.md index c532ca9..cfb129e 100644 --- a/packages/cnpj-dv/CHANGELOG.md +++ b/packages/cnpj-dv/CHANGELOG.md @@ -1,5 +1,11 @@ # lacus/cnpj-dv +## 1.2.0 + +### Improvements + +- **Error messages**: `CnpjCheckDigitsInputLengthException` refers to "characters" instead of "digits" to match alphanumeric input support. + ## 1.1.0 ### New Features diff --git a/packages/cnpj-dv/src/Exceptions/CnpjCheckDigitsInputLengthException.php b/packages/cnpj-dv/src/Exceptions/CnpjCheckDigitsInputLengthException.php index b1d4d48..808de6d 100644 --- a/packages/cnpj-dv/src/Exceptions/CnpjCheckDigitsInputLengthException.php +++ b/packages/cnpj-dv/src/Exceptions/CnpjCheckDigitsInputLengthException.php @@ -33,7 +33,7 @@ public function __construct( ? (string) strlen($evaluatedInput) : strlen($evaluatedInput) . ' in "' . $evaluatedInput . '"'; - parent::__construct("CNPJ input {$fmtActual} does not contain {$minExpectedLength} to {$maxExpectedLength} digits. Got {$fmtEvaluated}."); + parent::__construct("CNPJ input {$fmtActual} does not contain {$minExpectedLength} to {$maxExpectedLength} characters. Got {$fmtEvaluated}."); $this->actualInput = $actualInput; $this->evaluatedInput = $evaluatedInput; $this->minExpectedLength = $minExpectedLength; diff --git a/packages/cnpj-dv/tests/specs/Exceptions.spec.php b/packages/cnpj-dv/tests/specs/Exceptions.spec.php index 6eb4175..7635529 100644 --- a/packages/cnpj-dv/tests/specs/Exceptions.spec.php +++ b/packages/cnpj-dv/tests/specs/Exceptions.spec.php @@ -191,7 +191,7 @@ final class TestException extends CnpjCheckDigitsException $evaluatedInput = '12345'; $minExpectedLength = 12; $maxExpectedLength = 14; - $actualMessage = 'CNPJ input "'.$actualInput.'" does not contain '.$minExpectedLength.' to '.$maxExpectedLength.' digits. Got '.strlen($evaluatedInput).' in "'.$evaluatedInput.'".'; + $actualMessage = 'CNPJ input "'.$actualInput.'" does not contain '.$minExpectedLength.' to '.$maxExpectedLength.' characters. Got '.strlen($evaluatedInput).' in "'.$evaluatedInput.'".'; $exception = new CnpjCheckDigitsInputLengthException( $actualInput,