Fix formatting and clippy arithmetic warnings

- Apply cargo fmt fixes
- Replace raw arithmetic with saturating_mul/saturating_add in test
  helpers to satisfy clippy::arithmetic_side_effects lint

Author: LandynDev

chain-extensions/src/lib.rs

@@ -10,13 +10,13 @@ pub mod types;
 use crate::types::{FunctionId, Output};
 use codec::{Decode, Encode, MaxEncodedLen};
 use frame_support::{DebugNoBound, traits::Get};
-use sp_runtime::traits::Zero;
 use frame_system::RawOrigin;
 use pallet_contracts::chain_extension::{
     BufInBufOutState, ChainExtension, Environment, Ext, InitState, RetVal, SysConfig,
 };
 use pallet_subtensor_proxy as pallet_proxy;
 use pallet_subtensor_proxy::WeightInfo;
+use sp_runtime::traits::Zero;
 use sp_runtime::{DispatchError, Weight, traits::StaticLookup};
 use sp_std::marker::PhantomData;
 use substrate_fixed::types::U96F32;

chain-extensions/src/tests.rs

@@ -305,7 +305,7 @@ fn add_stake_limit_success_executes_within_price_guard() {
 
         pallet_subtensor::Pallet::<mock::Test>::add_balance_to_coldkey_account(
             &coldkey,
-            amount_raw + 1_000_000_000,
+            amount_raw.saturating_add(1_000_000_000),
         );
 
         let stake_before =
@@ -1001,17 +1001,24 @@ mod proxy_dispatch_tests {
         let netuid = mock::add_dynamic_network(&owner_hotkey, &owner_coldkey);
         mock::setup_reserves(
             netuid,
-            (amount_raw * 1_000).into(),
-            AlphaCurrency::from(amount_raw * 10_000),
+            amount_raw.saturating_mul(1_000).into(),
+            AlphaCurrency::from(amount_raw.saturating_mul(10_000)),
         );
         mock::register_ok_neuron(netuid, hotkey, real_coldkey, 0);
 
         pallet_subtensor::Pallet::<mock::Test>::add_balance_to_coldkey_account(
             &real_coldkey,
-            amount_raw + 1_000_000_000,
+            amount_raw.saturating_add(1_000_000_000),
         );
 
-        (real_coldkey, contract, hotkey, U256::from(10303), amount_raw, netuid.into())
+        (
+            real_coldkey,
+            contract,
+            hotkey,
+            U256::from(10303),
+            amount_raw,
+            netuid.into(),
+        )
     }
 
     fn stake_and_setup(
@@ -1049,9 +1056,13 @@ mod proxy_dispatch_tests {
                 0,
             );
 
-            let input =
-                (real_coldkey, hotkey, NetUid::from(netuid), TaoCurrency::from(amount_raw))
-                    .encode();
+            let input = (
+                real_coldkey,
+                hotkey,
+                NetUid::from(netuid),
+                TaoCurrency::from(amount_raw),
+            )
+                .encode();
             let mut env = MockEnv::new(FunctionId::ProxyAddStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env).unwrap();
@@ -1074,9 +1085,13 @@ mod proxy_dispatch_tests {
                 0,
             );
 
-            let input =
-                (real_coldkey, hotkey, NetUid::from(netuid), TaoCurrency::from(amount_raw))
-                    .encode();
+            let input = (
+                real_coldkey,
+                hotkey,
+                NetUid::from(netuid),
+                TaoCurrency::from(amount_raw),
+            )
+                .encode();
             let mut env = MockEnv::new(FunctionId::ProxyAddStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env).unwrap();
@@ -1089,13 +1104,20 @@ mod proxy_dispatch_tests {
         mock::new_test_ext(1).execute_with(|| {
             let (real_coldkey, contract, hotkey, _, amount_raw, netuid) = setup_staked_env(10);
 
-            let input =
-                (real_coldkey, hotkey, NetUid::from(netuid), TaoCurrency::from(amount_raw))
-                    .encode();
+            let input = (
+                real_coldkey,
+                hotkey,
+                NetUid::from(netuid),
+                TaoCurrency::from(amount_raw),
+            )
+                .encode();
             let mut env = MockEnv::new(FunctionId::ProxyAddStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env);
-            assert!(matches!(ret, Err(DispatchError::Other("Not authorized proxy"))));
+            assert!(matches!(
+                ret,
+                Err(DispatchError::Other("Not authorized proxy"))
+            ));
         });
     }
 
@@ -1110,13 +1132,20 @@ mod proxy_dispatch_tests {
                 0,
             );
 
-            let input =
-                (real_coldkey, hotkey, NetUid::from(netuid), TaoCurrency::from(amount_raw))
-                    .encode();
+            let input = (
+                real_coldkey,
+                hotkey,
+                NetUid::from(netuid),
+                TaoCurrency::from(amount_raw),
+            )
+                .encode();
             let mut env = MockEnv::new(FunctionId::ProxyAddStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env);
-            assert!(matches!(ret, Err(DispatchError::Other("Not authorized proxy"))));
+            assert!(matches!(
+                ret,
+                Err(DispatchError::Other("Not authorized proxy"))
+            ));
         });
     }
 
@@ -1131,13 +1160,20 @@ mod proxy_dispatch_tests {
                 10,
             );
 
-            let input =
-                (real_coldkey, hotkey, NetUid::from(netuid), TaoCurrency::from(amount_raw))
-                    .encode();
+            let input = (
+                real_coldkey,
+                hotkey,
+                NetUid::from(netuid),
+                TaoCurrency::from(amount_raw),
+            )
+                .encode();
             let mut env = MockEnv::new(FunctionId::ProxyAddStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env);
-            assert!(matches!(ret, Err(DispatchError::Other("Not authorized proxy"))));
+            assert!(matches!(
+                ret,
+                Err(DispatchError::Other("Not authorized proxy"))
+            ));
         });
     }
 
@@ -1315,7 +1351,10 @@ mod proxy_dispatch_tests {
             let mut env = MockEnv::new(FunctionId::ProxyTransferStakeV1, contract, input);
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env);
-            assert!(matches!(ret, Err(DispatchError::Other("Not authorized proxy"))));
+            assert!(matches!(
+                ret,
+                Err(DispatchError::Other("Not authorized proxy"))
+            ));
         });
     }
 
@@ -1422,15 +1461,14 @@ mod proxy_dispatch_tests {
 
             pallet_subtensor::Owner::<mock::Test>::insert(hotkey, real_coldkey);
             pallet_subtensor::OwnedHotkeys::<mock::Test>::insert(real_coldkey, vec![hotkey]);
-            pallet_subtensor::Uids::<mock::Test>::insert(
-                NetUid::from(netuid),
-                hotkey,
-                0u16,
-            );
+            pallet_subtensor::Uids::<mock::Test>::insert(NetUid::from(netuid), hotkey, 0u16);
 
             let input = (real_coldkey, NetUid::from(netuid), hotkey).encode();
-            let mut env =
-                MockEnv::new(FunctionId::ProxySetColdkeyAutoStakeHotkeyV1, contract, input);
+            let mut env = MockEnv::new(
+                FunctionId::ProxySetColdkeyAutoStakeHotkeyV1,
+                contract,
+                input,
+            );
 
             let ret = SubtensorChainExtension::<mock::Test>::dispatch(&mut env).unwrap();
             assert_success(ret);