fix: remove event-based api_server_connected — stale events caused restart loop

The connection_status_changed event handler was setting api_server_connected
to false based on stale "disconnected" events fired during Launching (before
Gateway finished logging in and labels became "connected"). When do_connected
checked the flag on first entry, it saw false and triggered an immediate
false-positive restart, doubling the launch time.

Match IBC's reactive model (GatewayDialogHandler): disconnect detection
happens via error dialog handling + active label inspection during Connected
state, NOT via async event state. The event is now logged for observability
only and does not drive state changes.

Author: Lcstyle

ibctl/src/state_machine/mod.rs

@@ -415,8 +415,13 @@ impl StateMachine {
                 );
             }
             AgentEvent::ConnectionStatusChanged { ref from, ref to, .. } => {
+                // Informational only — do NOT drive state changes from this event.
+                // Events can arrive with stale "disconnected" state while the state
+                // machine is still in Launching/Login, and would trigger false-positive
+                // restarts on first Connected entry. Match IBC's reactive model:
+                // disconnect detection happens via error dialog handling + active
+                // label inspection during Connected state.
                 log::warn!("Event: connection_status_changed {} -> {}", from, to);
-                self.api_server_connected = to == "connected";
             }
         }
 
@@ -1283,23 +1288,6 @@ impl StateMachine {
             self.start_socat(api_port, socat_port);
         }
 
-        // --- API Server disconnect detection (real-time event from Java agent) ---
-        if !self.api_server_connected {
-            log::warn!("API Server DISCONNECTED (detected via connection_status_changed event)");
-            self.stop_socat();
-            self.abort_client_id_task();
-            self.connected_window_class = None;
-            self.handler_registry.reset();
-            // Click OK on any error dialogs before restarting
-            if let Ok(windows) = self.agent_client.list_windows().await {
-                for w in &windows {
-                    let _ = self.agent_client.click_button(w.id, "OK").await;
-                }
-            }
-            self.api_server_connected = true; // Reset for next cycle
-            return Ok(State::Restarting);
-        }
-
         // --- Event-driven dialog detection (observation cache) ---
         // Check the observation cache for re-login dialogs and session loss.
         // Events update the cache in real-time; this is instant (no I/O).

ibctl/src/state_machine/types.rs

@@ -206,9 +206,6 @@ pub struct StateMachine {
     /// session loss: if the main window's class changes (e.g. ibgateway.ay → ibgateway.az),
     /// Gateway reverted to the login form without showing a RE-LOGIN dialog.
     pub(super) connected_window_class: Option<String>,
-    /// API Server connection status from Java agent's connection_status_changed event.
-    /// Updated in real-time by the event stream. Checked by do_connected handler.
-    pub(super) api_server_connected: bool,
     /// 2FA device selection state — survives tokio::select! cancellation.
     /// Set true after device is selected and OK clicked. Reset on state transitions
     /// that start a new login cycle.
@@ -276,7 +273,6 @@ impl StateMachine {
             client_id_rx: None,
             relogin_attempts: 0,
             connected_window_class: None,
-            api_server_connected: true,
             twofa_device_selected: false,
             twofa_seen: false,
             twofa_gone_at: None,