Change conditions for displaying deprecated event warnings.

Prevents warnings when using AsyncPlayerChatEvent on Paper.

Author: RezzedUp

events-bukkit/src/main/java/community/leaf/eventful/bukkit/EventsImpl.java

@@ -121,24 +121,27 @@ private static void checkThenWarnIfDeprecatedEvent(Plugin plugin, Class<? extend
             Warning.WarningState warningState = plugin.getServer().getWarningState();
             Optional<Warning> warning = annotation(clazz, Warning.class);
 
-            // Differs from bukkit: always print warnings unless explicitly turned off.
-            if (warningState == Warning.WarningState.OFF) { break; }
+            boolean shouldBeWarned = warning.filter(Warning::value).isPresent();
+            boolean canBeWarned = warningState != Warning.WarningState.OFF;
 
-            plugin.getLogger().log(
-                Level.WARNING,
-                String.format(
-                    "%s has registered a listener for %s, but the event is deprecated (%s). %s.",
-                    plugin.getDescription().getFullName(),
-                    eventType.getSimpleName(),
-                    clazz.getName(),
-                    warning.map(Warning::reason)
-                        .filter(Predicate.not(String::isBlank))
-                        .orElse("Server performance will be affected")
-                ),
-                (warningState == Warning.WarningState.ON) ? new AuthorNagException(null) : null
-            );
-            
-            return;
+            if (shouldBeWarned && canBeWarned)
+            {
+                plugin.getLogger().log(
+                    Level.WARNING,
+                    String.format(
+                        "%s has registered a listener for %s, but the event is deprecated (%s). %s.",
+                        plugin.getDescription().getFullName(),
+                        eventType.getSimpleName(),
+                        clazz.getName(),
+                        warning.map(Warning::reason)
+                            .filter(Predicate.not(String::isBlank))
+                            .orElse("Server performance will be affected")
+                    ),
+                    (warningState == Warning.WarningState.ON) ? new AuthorNagException(null) : null
+                );
+                
+                return; // already warned, don't spam
+            }
         }
     }
 

examples/events-example-bukkit/src/main/java/community/leaf/examples/eventful/bukkit/ExampleEventfulPlugin.java

@@ -17,6 +17,7 @@
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
+import org.bukkit.event.player.AsyncPlayerChatEvent;
 import org.bukkit.event.player.PlayerDropItemEvent;
 import org.bukkit.event.player.PlayerInteractEvent;
 import org.bukkit.event.player.PlayerPreLoginEvent;
@@ -131,4 +132,10 @@ public void onPlayerSneak(PlayerToggleSneakEvent event)
             throw new RuntimeException("Oopsies (example exception)");
         }
     }
+    
+    @EventListener(ListenerOrder.FIRST)
+    public void onPlayerChat(AsyncPlayerChatEvent event)
+    {
+        event.setMessage(event.getMessage().replace("->", "→").replace("<-", "←"));
+    }
 }