Skip to content

test: consolidate hand-rolled ConfigStore mocks (3 copies, taxes every new store method) #1395

Description

@cristim

Duplication audit: 3 hand-rolled config.StoreInterface mocks (internal/mocks/stores.go MockConfigStore, internal/analytics/collector_test.go mockConfigStore, internal/server/test_helpers_test.go mockConfigStoreForHealth) must each gain a stub for EVERY new StoreInterface method - L5 alone had to touch all 3 for 2 new methods; this recurs on #1362/#1368/etc. Consolidate: have the smaller mocks embed mocks.MockConfigStore (override only what they exercise), or split StoreInterface into role interfaces. Reduces the per-method tax + the interface-widening-completeness-trap surface.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions