Fix healt endpoint, tests

soundstorm · soundstorm · commit 096e9ee4fa83 · 2026-03-04T15:45:27.000+01:00
diff --git a/app/main.py b/app/main.py
@@ -1,10 +1,11 @@
 from contextlib import asynccontextmanager
 
-from fastapi import FastAPI, Request
+from fastapi import Depends, FastAPI, Request
 from fastapi.exceptions import HTTPException
 from fastapi.responses import HTMLResponse
 from fastapi.responses import JSONResponse as _JSONResponse
 from sqlalchemy import text
+from sqlalchemy.orm import Session
 
 
 class JSONResponse(_JSONResponse):
@@ -15,7 +16,7 @@ class JSONResponse(_JSONResponse):
 
 from app.api.v1.router import api_router
 from app.config import settings
-from app.database import engine
+from app.database import get_db
 from app.web.router import router as web_router
 import pathlib
 
@@ -47,6 +48,7 @@ async def lifespan(app: FastAPI):
   <meta charset="UTF-8">
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>Login Required – MakerSpaceAPI</title>
+  <link rel="icon" type="image/svg+xml" href="/static/favicon.svg">
   <link rel="stylesheet" href="/static/css/tailwind.css">
 </head>
 <body class="bg-gray-50 text-gray-900 min-h-screen flex items-center justify-center">
@@ -78,12 +80,11 @@ async def http_exception_handler(request: Request, exc: HTTPException) -> JSONRe
     same_site="lax",
 )
 
-@app.get("/api/health", tags=["health"], include_in_schema=True)
-def health():
+@app.get("/api/health", tags=["health"])
+def health(db: Session = Depends(get_db)):
     """Public health check. Returns 200 when the database is reachable."""
     try:
-        with engine.connect() as conn:
-            conn.execute(text("SELECT 1"))
+        db.execute(text("SELECT 1"))
         return {"status": "ok", "database": "ok"}
     except Exception:
         return JSONResponse({"status": "error", "database": "unreachable"}, status_code=503)
diff --git a/tests/test_health.py b/tests/test_health.py
@@ -0,0 +1,16 @@
+from unittest.mock import MagicMock, patch
+
+from sqlalchemy.exc import OperationalError
+
+
+def test_health_ok(client):
+    resp = client.get("/api/health")
+    assert resp.status_code == 200
+    assert resp.json() == {"status": "ok", "database": "ok"}
+
+
+def test_health_db_unreachable(client):
+    with patch("app.main.Session.execute", side_effect=OperationalError("x", {}, None)):
+        resp = client.get("/api/health")
+    assert resp.status_code == 503
+    assert resp.json() == {"status": "error", "database": "unreachable"}
