Skip to content

Commit 2eaae22

Browse files
nasdannasdan
committed
Fix validation result builder specs
1 parent 84a68c4 commit 2eaae22

1 file changed

Lines changed: 75 additions & 24 deletions

File tree

‎lib/src/spec/validationsResultBuilder.spec.ts‎

Lines changed: 75 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ describe('ValidationsResultBuilder ', () => {
104104
expect(result.succeeded).to.be.true;
105105
});
106106

107-
it('Spec #8 => should returns new FormValidationResult equals { fieldErrors: [] } ' +
107+
it('Spec #8 => should returns new FormValidationResult equals { fieldErrors: {} } ' +
108108
'when passing fieldValidationResults equals undefined', () => {
109109
//Arrange
110110
let fieldValidationResults = undefined;
@@ -113,10 +113,10 @@ describe('ValidationsResultBuilder ', () => {
113113
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
114114

115115
//Assert
116-
expect(result.fieldErrors).to.be.empty;
116+
expect(result.fieldErrors).to.deep.equals({});
117117
});
118118

119-
it('Spec #9 => should returns new FormValidationResult equals { fieldErrors: [] } ' +
119+
it('Spec #9 => should returns new FormValidationResult equals { fieldErrors: {} } ' +
120120
'when passing fieldValidationResults equals null', () => {
121121
//Arrange
122122
let fieldValidationResults = null;
@@ -125,10 +125,10 @@ describe('ValidationsResultBuilder ', () => {
125125
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
126126

127127
//Assert
128-
expect(result.fieldErrors).to.be.empty;
128+
expect(result.fieldErrors).to.deep.equals({});
129129
});
130130

131-
it('Spec #10 => should returns new FormValidationResult equals { fieldErrors: [] } ' +
131+
it('Spec #10 => should returns new FormValidationResult equals { fieldErrors: {} } ' +
132132
'when passing fieldValidationResults equals empty', () => {
133133
//Arrange
134134
let fieldValidationResults = [];
@@ -137,11 +137,11 @@ describe('ValidationsResultBuilder ', () => {
137137
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
138138

139139
//Assert
140-
expect(result.fieldErrors).to.be.empty;
140+
expect(result.fieldErrors).to.deep.equals({});
141141
});
142142

143143
it('Spec #11 => should returns new FormValidationResult equals ' +
144-
'{ fieldErrors: [{ key: "test" }] } with length equals 1 ' +
144+
'{ fieldErrors: { test: { key: "test", succeeded: false, errorMessage: "", type: "" } } }' +
145145
'when passing fieldValidationResults with one item equals { key: "test" }', () => {
146146
//Arrange
147147
let fieldValidationResult = new FieldValidationResult();
@@ -152,12 +152,18 @@ describe('ValidationsResultBuilder ', () => {
152152
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
153153

154154
//Assert
155-
expect(result.fieldErrors).to.have.length(1);
156-
expect(result.fieldErrors[0].key).to.be.equal('test');
155+
expect(result.fieldErrors).to.deep.equal({
156+
test: {
157+
key: 'test',
158+
succeeded: false,
159+
errorMessage: '',
160+
type: '',
161+
},
162+
});
157163
});
158164

159165
it('Spec #12 => should returns new FormValidationResult equals ' +
160-
'{ fieldErrors: [] } with length equals 0 ' +
166+
'{ fieldErrors: {} } without properties ' +
161167
'when passing fieldValidationResults with one item equals { key: null }', () => {
162168
//Arrange
163169
let fieldValidationResult = new FieldValidationResult();
@@ -168,11 +174,11 @@ describe('ValidationsResultBuilder ', () => {
168174
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
169175

170176
//Assert
171-
expect(result.fieldErrors).to.have.length(0);
177+
expect(result.fieldErrors).to.deep.equals({});
172178
});
173179

174180
it('Spec #13 => should returns new FormValidationResult equals ' +
175-
'{ fieldErrors: [] } with length equals 0 ' +
181+
'{ fieldErrors: {} } without properties ' +
176182
'when passing fieldValidationResults with one item equals { key: undefined }', () => {
177183
//Arrange
178184
let fieldValidationResult = new FieldValidationResult();
@@ -183,11 +189,11 @@ describe('ValidationsResultBuilder ', () => {
183189
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
184190

185191
//Assert
186-
expect(result.fieldErrors).to.have.length(0);
192+
expect(result.fieldErrors).to.deep.equals({});
187193
});
188194

189195
it('Spec #14 => should returns new FormValidationResult equals ' +
190-
'{ fieldErrors: [] } with length equals 0 ' +
196+
'{ fieldErrors: {} } without properties ' +
191197
'when passing fieldValidationResults with one item equals { key: "" }', () => {
192198
//Arrange
193199
let fieldValidationResult = new FieldValidationResult();
@@ -198,11 +204,11 @@ describe('ValidationsResultBuilder ', () => {
198204
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
199205

200206
//Assert
201-
expect(result.fieldErrors).to.have.length(0);
207+
expect(result.fieldErrors).to.deep.equals({});
202208
});
203209

204210
it('Spec #15 => should returns new FormValidationResult equals ' +
205-
'{ fieldErrors: [] } with length equals 0 ' +
211+
'{ fieldErrors: {} } without properties ' +
206212
'when passing fieldValidationResults with one item equals { key: "_GLOBAL_FORM_" }', () => {
207213
//Arrange
208214
let fieldValidationResult = new FieldValidationResult();
@@ -213,7 +219,7 @@ describe('ValidationsResultBuilder ', () => {
213219
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
214220

215221
//Assert
216-
expect(result.fieldErrors).to.have.length(0);
222+
expect(result.fieldErrors).to.deep.equals({});
217223
});
218224

219225
it('Spec #16 => should returns new FormValidationResult equals ' +
@@ -296,7 +302,7 @@ describe('ValidationsResultBuilder ', () => {
296302
});
297303

298304
it('Spec #21 => should returns new FormValidationResult equals ' +
299-
'{ fieldErrors: [{ key: "test" }] } with length equals 1 ' +
305+
'{ fieldErrors: { test: { key: "test" } } } ' +
300306
'when passing fieldValidationResults with two item first equals { key: "test" }' +
301307
'and second equals null', () => {
302308
//Arrange
@@ -311,12 +317,18 @@ describe('ValidationsResultBuilder ', () => {
311317
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
312318

313319
//Assert
314-
expect(result.fieldErrors).to.have.length(1);
315-
expect(result.fieldErrors[0].key).to.be.equal('test');
320+
expect(result.fieldErrors).to.deep.equal({
321+
test: {
322+
key: 'test',
323+
succeeded: false,
324+
errorMessage: '',
325+
type: '',
326+
},
327+
});
316328
});
317329

318330
it('Spec #22 => should returns new FormValidationResult equals ' +
319-
'{ fieldErrors: [{ key: "test" }] } with length equals 1 ' +
331+
'{ fieldErrors: { test: { key: "test" } } } ' +
320332
'when passing fieldValidationResults with two item first equals { key: "test" }' +
321333
'and second equals undefined', () => {
322334
//Arrange
@@ -331,11 +343,50 @@ describe('ValidationsResultBuilder ', () => {
331343
let result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
332344

333345
//Assert
334-
expect(result.fieldErrors).to.have.length(1);
335-
expect(result.fieldErrors[0].key).to.be.equal('test');
346+
expect(result.fieldErrors).to.deep.equal({
347+
test: {
348+
key: 'test',
349+
succeeded: false,
350+
errorMessage: '',
351+
type: '',
352+
},
353+
});
336354
});
337355

338356
it('Spec #23 => should returns new FormValidationResult equals ' +
357+
'{ fieldErrors: { test1: { key: "test1" }, test2: { key: "test2" } } } ' +
358+
'when passing fieldValidationResults with two item first equals { key: "test1" }' +
359+
'and second equals { key: "test2" }', () => {
360+
//Arrange
361+
const fieldValidationResult1 = new FieldValidationResult();
362+
fieldValidationResult1.key = 'test1';
363+
364+
const fieldValidationResult2 = new FieldValidationResult();
365+
fieldValidationResult2.key = 'test2';
366+
367+
const fieldValidationResults = [fieldValidationResult1, fieldValidationResult2];
368+
369+
//Act
370+
const result = validationsResultBuilder.buildFormValidationsResult(fieldValidationResults);
371+
372+
//Assert
373+
expect(result.fieldErrors).to.deep.equal({
374+
test1: {
375+
key: 'test1',
376+
succeeded: false,
377+
errorMessage: '',
378+
type: '',
379+
},
380+
test2: {
381+
key: 'test2',
382+
succeeded: false,
383+
errorMessage: '',
384+
type: '',
385+
},
386+
});
387+
});
388+
389+
it('Spec #24 => should returns new FormValidationResult equals ' +
339390
'{ formGlobalErrors: [{ key: "_GLOBAL_FORM_" }] } with length equals 1 ' +
340391
'when passing fieldValidationResults with two item first equals { key: "_GLOBAL_FORM_" }' +
341392
'and second equals null', () => {
@@ -355,7 +406,7 @@ describe('ValidationsResultBuilder ', () => {
355406
expect(result.formGlobalErrors[0].key).to.be.equal('_GLOBAL_FORM_');
356407
});
357408

358-
it('Spec #24 => should returns new FormValidationResult equals ' +
409+
it('Spec #25 => should returns new FormValidationResult equals ' +
359410
'{ formGlobalErrors: [{ key: "_GLOBAL_FORM_" }] } with length equals 1 ' +
360411
'when passing fieldValidationResults with two item first equals { key: "_GLOBAL_FORM_" }' +
361412
'and second equals undefined', () => {

0 commit comments

Comments
 (0)