Skip to content

Commit 73172ab

Browse files
authored
Merge pull request #7 from Lemoncode/feature/Implement_projects_layout
Feature/implement projects layout
2 parents a45001e + df75b51 commit 73172ab

24 files changed

Lines changed: 412 additions & 22 deletions

src/pods/employee/api/employee.api-model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ export interface Employee {
1010
export interface ProjectSummary {
1111
id: string;
1212
isAssigned?: boolean;
13-
employeeName: string;
13+
projectName: string;
1414
}

src/pods/employee/api/employee.mock-data.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,22 @@ const mockProjectSummaryList: ProjectSummary[] = [
44
{
55
id: '1',
66
isAssigned: true,
7-
employeeName: 'Mapfre',
7+
projectName: 'Mapfre',
88
},
99
{
1010
id: '2',
1111
isAssigned: false,
12-
employeeName: 'Bankia',
12+
projectName: 'Bankia',
1313
},
1414
{
1515
id: '3',
1616
isAssigned: false,
17-
employeeName: 'Vacaciones',
17+
projectName: 'Vacaciones',
1818
},
1919
{
2020
id: '4',
2121
isAssigned: true,
22-
employeeName: 'Baja',
22+
projectName: 'Baja',
2323
},
2424
];
2525

src/pods/employee/components/project-row.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const EmployeeRowComponent: React.FunctionComponent<Props> = ({
1717
<CellComponent>
1818
<Checkbox checked={row.isAssigned} color="primary" />
1919
</CellComponent>
20-
<CellComponent>{row.employeeName}</CellComponent>
20+
<CellComponent>{row.projectName}</CellComponent>
2121
</RowComponent>
2222
);
2323
};

src/pods/employee/employee.component.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
TabListComponent,
55
TabPanelComponent,
66
} from 'common/components';
7+
import AppBar from '@material-ui/core/AppBar';
78
import { DataComponent, ProjectComponent, ReportComponent } from './components';
89
import { Employee } from './employee.vm';
910
import * as classes from './employee.styles';
@@ -26,11 +27,13 @@ export const EmployeeComponent: React.FunctionComponent<Props> = ({
2627
const [tab, setTab] = React.useState(0);
2728
return (
2829
<>
29-
<TabListComponent value={tab} onChange={setTab}>
30-
<TabComponent label="Datos" />
31-
<TabComponent label="Proyectos" disabled={!isEditMode} />
32-
<TabComponent label="Informes" disabled={!isEditMode} />
33-
</TabListComponent>
30+
<AppBar position="static">
31+
<TabListComponent value={tab} onChange={setTab}>
32+
<TabComponent label="Datos" />
33+
<TabComponent label="Proyectos" disabled={!isEditMode} />
34+
<TabComponent label="Informes" disabled={!isEditMode} />
35+
</TabListComponent>
36+
</AppBar>
3437
<TabPanelComponent value={tab} index={0}>
3538
<DataComponent
3639
employee={employee}

src/pods/employee/employee.container.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ export const EmployeeContainer: React.FunctionComponent = () => {
1616
const [isEditMode, setIsEditMode] = React.useState<boolean>(false);
1717
const { showMessage } = useSnackbarContext();
1818

19-
const onLoadProjectSummary = async () => {
19+
const onLoadEmployee = async () => {
2020
try {
2121
const apiEmployee = await trackPromise(getEmployeeById(id));
2222
const viewModelEmployee = mapEmployeeFromApiToVm(apiEmployee);
2323
setEmployee(viewModelEmployee);
2424
} catch (error) {
2525
error &&
26-
showMessage('Ha ocurrido un error al cargar los proyectos', 'error');
26+
showMessage('Ha ocurrido un error al cargar el empleado', 'error');
2727
}
2828
};
2929

@@ -44,7 +44,7 @@ export const EmployeeContainer: React.FunctionComponent = () => {
4444
const isEditMode = isEditModeHelper(id);
4545
setIsEditMode(isEditMode);
4646
if (isEditMode) {
47-
onLoadProjectSummary();
47+
onLoadEmployee();
4848
}
4949
}, []);
5050

src/pods/employee/employee.mappers.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ describe('./pods/employee/employee.mappers', () => {
9090
projects: [
9191
{
9292
id: 'test id',
93-
employeeName: 'test employee name',
93+
projectName: 'test employee name',
9494
isAssigned: true,
9595
},
9696
],
@@ -105,7 +105,7 @@ describe('./pods/employee/employee.mappers', () => {
105105
projects: [
106106
{
107107
id: 'test id',
108-
employeeName: 'test employee name',
108+
projectName: 'test employee name',
109109
isAssigned: true,
110110
},
111111
],

src/pods/employee/employee.vm.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface Employee {
1010
export interface ProjectSummary {
1111
id: string;
1212
isAssigned?: boolean;
13-
employeeName: string;
13+
projectName: string;
1414
}
1515

1616
export const createEmptyEmployee = (): Employee => ({
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { Project } from './project.api-model';
2+
import { mockProject } from './project.mock-data';
3+
4+
export const getProjectById = async (id: string): Promise<Project> => {
5+
return mockProject;
6+
};

src/pods/project/api/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './employee.api';
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
export interface Project {
2+
id: string;
3+
name: string;
4+
externalId?: string;
5+
comments?: string;
6+
isActive: boolean;
7+
employees: EmployeeSummary[];
8+
}
9+
10+
export interface EmployeeSummary {
11+
id: string;
12+
isAssigned?: boolean;
13+
employeeName: string;
14+
}

0 commit comments

Comments
 (0)