Skip to content

Commit 27ecf7f

Browse files
committed
Add unit test. Undo 'arg' fix, not needed actually.
1 parent a0db03a commit 27ecf7f

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

src/trackPromise.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ export const trackPromise = (promise, area) => {
1515
const promiseInProgress = anyPromiseInProgress(area);
1616
emitter.emit(promiseCounterUpdateEventId, promiseInProgress, area);
1717

18-
const onResolveHandler = (arg) => {
19-
decrementPromiseCounter(area);
20-
return arg;
21-
}
18+
const onResolveHandler = () => decrementPromiseCounter(area);
2219
promise.then(onResolveHandler, onResolveHandler);
2320

2421
return promise;

src/trackPromise.test.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,23 @@ describe('trackPromise', () => {
8686
done();
8787
});
8888
});
89+
90+
// Promise chaining working properly.
91+
it('Promise returned must handle transparently the result when resolved', (done) => {
92+
// Arrange
93+
const expectedPromiseResult = "promise result";
94+
const promise = Promise.resolve(expectedPromiseResult);
95+
96+
// Act
97+
const trackedPromise = trackPromise(promise);
98+
99+
// Assert
100+
trackedPromise.then((trackedPromiseResult) => {
101+
expect(trackedPromiseResult).toEqual(expectedPromiseResult);
102+
done();
103+
});
104+
});
105+
89106
});
90107

91108
describe('using custom area', () => {

0 commit comments

Comments
 (0)