Merge pull request #89 from nickxbs/fix/promiseInProgress_UnmountedComponent

brauliodiez · web-flow · commit 2956fafe29c6 · 2020-11-11T11:59:57.000+01:00
Fix mem leak warning on unmounted component
diff --git a/src/trackerHook.js b/src/trackerHook.js
@@ -56,7 +56,7 @@ export const usePromiseTracker = (outerConfig = defaultConfig) => {
       ? setPromiseInProgress(true)
       : setTimeout(() => {
           // Check here ref to internalPromiseInProgress
-          if (latestInternalPromiseInProgress.current) {
+          if (isMounted.current && latestInternalPromiseInProgress.current) {
             setPromiseInProgress(true);
           }
         }, config.delay);

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export const usePromiseTracker = (outerConfig = defaultConfig) => {`
`56`	`56`	`? setPromiseInProgress(true)`
`57`	`57`	`: setTimeout(() => {`
`58`	`58`	`// Check here ref to internalPromiseInProgress`
`59`		`- if (latestInternalPromiseInProgress.current) {`
	`59`	`+ if (isMounted.current && latestInternalPromiseInProgress.current) {`
`60`	`60`	`setPromiseInProgress(true);`
`61`	`61`	`}`
`62`	`62`	`}, config.delay);`