implemented remove function

Author: Levi-B4

DSDoublyLL/dsdoublyll.h

@@ -228,24 +228,21 @@ void DSDoublyLL<T>::insert(int index, T data){
         return;
     }
 
-    DSNode<T>* newNode = new DSNode<T>(data);
-
-    //ToDo: throw an "index out of bounds" error
-    DSNode<T>* current = head;
-    for(int i = 0; i < index - 1; i++){
-        current = current->next;
+    if(index == numIndexes){
+        pushBack(data);
+        return;
     }
 
-    newNode->next = current->next;
-    newNode->prev = current;
+    DSNode<T>* nodeBefore = getNodeAt(index - 1);
 
-    current->next = newNode;
+    DSNode<T>* newNode = new DSNode<T>(data);
 
-    if(newNode->next == nullptr){
-        tail = newNode;
-    }else {
-        newNode->next->prev = newNode;
-    }
+    newNode->next = nodeBefore->next;
+    newNode->prev = nodeBefore;
+
+    nodeBefore->next = newNode;
+
+    newNode->next->prev = newNode;
 
     numIndexes++;
 }
@@ -256,7 +253,41 @@ void DSDoublyLL<T>::insert(int index, T data){
  */
 template <class T>
 void DSDoublyLL<T>::remove(int index){
-    //ToDo: remove
+    if(index == 0){
+        DSNode<T>* temp = head->next;
+        delete head;
+
+        head = temp;
+        head->prev = nullptr;
+
+        numIndexes--;
+        return;
+    }
+
+    if(index == numIndexes - 1){
+        DSNode<T>* temp = tail->prev;
+        delete tail;
+
+        tail = temp;
+        tail->next = nullptr;
+
+        numIndexes--;
+        return;
+    }
+
+    DSNode<T>* target = getNodeAt(index);
+
+    target->prev->next = target->next;
+
+    if(target->next != nullptr){
+        target->next->prev = target->prev;
+    } else {
+        tail = target->prev;
+    }
+
+    numIndexes--;
+
+    delete target;
 }
 
 /**
@@ -326,11 +357,7 @@ void DSDoublyLL<T>::popBack(){
 template<class T>
 int DSDoublyLL<T>::size()
 {
-    int total = 0;
-    for(DSNode<T>* current = head; current != nullptr; current = current->next){
-        total++;
-    }
-    return total;
+    return numIndexes;
 }
 
 /**
@@ -457,6 +484,8 @@ template <class T>
 DSNode<T>* DSDoublyLL<T>::getNodeAt(int index) const{
     DSNode<T>* current;
 
+    //ToDo: throw an "index out of bounds" error
+
     // set indexing to start from the closer end node
     if(index < 0){
         index = numIndexes + index;

test.cpp

@@ -410,34 +410,43 @@ TEST_CASE("Data_Structures_Doubly_Linked_List", "[Doubly_Linked_List][Data_Struc
         REQUIRE(numList1[1] == 1);
     }
 
+    SECTION("Other Operators"){
+        // adding
+        REQUIRE(numList3 == numList1 + numList2);
+
+        // adding and setting equal
+        numList1 += numList2;
+        REQUIRE(numList3 == numList1);
+        numList1 = numList1Copy;
+
+        // size
+        REQUIRE(numList1.size() == 3);
+    }
+
     SECTION("Insertion and Removal"){
+        // insertion
         numList4.insert(0, 0);
         numList4.insert(3, 3);
         numList4.insert(5, 5);
 
         REQUIRE(numList4 == numList3);
 
-        /*numList4.remove(5);
+        // removal
+        numList4.remove(5);
         numList4.remove(1);
         numList4.remove(0);
         numList4.remove(0);
 
         numList4.insert(2, 5);
 
-        REQUIRE(numList4 == numList2);*/
-    }
-
-    SECTION("Other Operators"){
-        // adding
-        REQUIRE(numList3 == numList1 + numList2);
+        REQUIRE(numList4 == numList2);
 
-        // adding and setting equal
-        numList1 += numList2;
-        REQUIRE(numList3 == numList1);
-        numList1 = numList1Copy;
+        // reset list
+        numList4.remove(2);
+        numList4.remove(0);
 
-        // size
-        REQUIRE(numList1.size() == 3);
+        numList4.pushFront(2);
+        numList4.pushFront(1);
     }
 
     SECTION("popping"){