Skip to content

Commit 0c915cd

Browse files
committed
Add repo existing check tests
Update ReleaseVersion regex to also accept version with less than 3 values
1 parent 9ae43c3 commit 0c915cd

4 files changed

Lines changed: 45 additions & 1 deletion

File tree

.idea/gradle.xml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/sonarlint/issuestore/index.pb

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main/java/com/lezurex/githubversionchecker/ReleaseVersion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public ReleaseVersion(String versionString) {
3636
}
3737

3838
private void parseVersionString(String s) {
39-
final Pattern pattern = Pattern.compile("[vV]?(\\d+)\\.(\\d+)\\.(\\d+)");
39+
final Pattern pattern = Pattern.compile("[vV]?(\\d+)\\.?(\\d+)?\\.?(\\d+)?");
4040
final Matcher matcher = pattern.matcher(s);
4141

4242
if (matcher.find()) {
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
package com.lezurex.githubversionchecker;
2+
3+
import com.lezurex.githubversionchecker.exceptions.RepoNotFoundException;
4+
import org.junit.jupiter.api.DisplayName;
5+
import org.junit.jupiter.api.Test;
6+
7+
import static org.junit.jupiter.api.Assertions.*;
8+
9+
class GithubVersionCheckerTest {
10+
11+
@Test
12+
@DisplayName("Setup with valid repo")
13+
void setupValidRepo() {
14+
ReleaseVersion releaseVersion = new ReleaseVersion("0.1.1");
15+
assertDoesNotThrow(() -> {
16+
GithubVersionChecker versionChecker = new GithubVersionChecker("Lezurex", "github-version-checker", releaseVersion);
17+
}, "Repo validation failed!");
18+
}
19+
20+
@Test
21+
@DisplayName("Setup with invalid repo")
22+
void setupInvalidRepo() {
23+
ReleaseVersion releaseVersion = new ReleaseVersion("0.1.1");
24+
assertThrows(RepoNotFoundException.class, () -> new GithubVersionChecker("Lezurex", "doesnotexist", releaseVersion), "Repo validation di not fail!");
25+
}
26+
27+
}

0 commit comments

Comments
 (0)