Skip to content

Commit 16ce71a

Browse files
committed
🔖 prepare release v1.0.1
And some formatting and deprecations
1 parent 461a4a5 commit 16ce71a

5 files changed

Lines changed: 34 additions & 42 deletions

File tree

.github/workflows/build-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ jobs:
4242
uses: gradle/actions/setup-gradle@af1da67850ed9a4cedd57bfd976089dd991e2582 # v4.0.0
4343

4444
- name: Test with Gradle Wrapper
45-
run: ./gradlew verify
45+
run: ./gradlew test

README.md

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -8,33 +8,12 @@ A java library for checking for new releases on GitHub
88

99
## Download
1010

11-
Gradle:
12-
```gradle
13-
maven {
14-
url "https://repo.voxcrafter.dev/repository/maven-releases/"
15-
}
16-
17-
dependencies {
18-
implementation 'com.lezurex.githubversionchecker:1.0.0'
19-
}
20-
```
21-
22-
Maven:
23-
```xml
24-
<dependency>
25-
<groupId>com.lezurex</groupId>
26-
<artifactId>github-version-checker</artifactId>
27-
<version>1.0.0</version>
28-
<scope>compile</scope>
29-
</dependency>
30-
31-
<repository>
32-
<id>voxcrafter-repo</id>
33-
<url>https://repo.voxcrafter.dev/repository/maven-releases/</url>
34-
</repository>
35-
```
11+
This library is published as `com.lezurex.github-version-checker` on GitHub
12+
Packages. Take a look at [this](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-gradle-registry#using-a-published-package)
13+
to see how to configure the GitHub Package Registry for your project.
3614

3715
## Usage
16+
3817
```java
3918
public class Example {
4019

@@ -58,4 +37,4 @@ public class Example {
5837
}
5938

6039
}
61-
```
40+
```

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ plugins {
44
}
55

66
group 'com.lezurex'
7-
version '1.0.0'
7+
version '1.0.1'
88

99
repositories {
1010
mavenCentral()

src/main/java/com/lezurex/githubversionchecker/GithubVersionChecker.java

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
import java.io.BufferedReader;
1111
import java.io.IOException;
1212
import java.io.InputStreamReader;
13+
import java.net.URI;
14+
import java.net.URISyntaxException;
1315
import java.net.URL;
1416

1517
import static java.net.HttpURLConnection.HTTP_OK;
@@ -33,20 +35,23 @@ public class GithubVersionChecker {
3335
* @param currentVersion The current version running
3436
* @param includePreReleases Whether pre releases should be tested (default: false)
3537
*/
36-
public GithubVersionChecker(String username, String repo, ReleaseVersion currentVersion, boolean includePreReleases) {
38+
public GithubVersionChecker(String username, String repo, ReleaseVersion currentVersion,
39+
boolean includePreReleases) {
3740
this.username = username;
3841
this.repo = repo;
3942
this.currentVersion = currentVersion;
4043
this.includePreReleases = includePreReleases;
4144

4245
try {
43-
URL url = new URL(String.format("https://api.github.com/repos/%s/%s", this.username, this.repo));
46+
URL url = new URI(
47+
String.format("https://api.github.com/repos/%s/%s", this.username, this.repo))
48+
.toURL();
4449
HttpsURLConnection con = (HttpsURLConnection) url.openConnection();
4550
con.setRequestMethod("GET");
4651
if (con.getResponseCode() != HTTP_OK) {
4752
throw new RepoNotFoundException(this.username, this.repo);
4853
}
49-
} catch (IOException e) {
54+
} catch (IOException | URISyntaxException e) {
5055
e.printStackTrace();
5156
}
5257
}
@@ -65,24 +70,27 @@ public CheckResult check() {
6570
if (this.includePreReleases)
6671
queryURL = "https://api.github.com/repos/%s/%s/releases?per_page=1";
6772
try {
68-
URL url = new URL(String.format(queryURL, this.username, this.repo));
73+
URL url = new URI(String.format(queryURL, this.username, this.repo)).toURL();
6974
HttpsURLConnection con = (HttpsURLConnection) url.openConnection();
7075
con.setRequestMethod("GET");
71-
if (con.getResponseCode() != HTTP_OK) throw new NoReleaseFoundException(this.username, this.repo);
76+
if (con.getResponseCode() != HTTP_OK)
77+
throw new NoReleaseFoundException(this.username, this.repo);
7278

7379
BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream()));
7480

7581
JsonObject releaseData;
7682
if (this.includePreReleases) {
7783
JsonArray jsonArray = JsonParser.parseReader(in).getAsJsonArray();
78-
if (jsonArray.size() == 0) throw new NoReleaseFoundException(this.username, this.repo);
84+
if (jsonArray.size() == 0)
85+
throw new NoReleaseFoundException(this.username, this.repo);
7986
releaseData = jsonArray.get(0).getAsJsonObject();
8087
} else
8188
releaseData = JsonParser.parseReader(in).getAsJsonObject();
8289
in.close();
8390
con.disconnect();
8491

85-
ReleaseVersion githubVersion = new ReleaseVersion(releaseData.get("tag_name").getAsString());
92+
ReleaseVersion githubVersion =
93+
new ReleaseVersion(releaseData.get("tag_name").getAsString());
8694
String pageLink = releaseData.get("html_url").getAsString();
8795
switch (this.currentVersion.compareTo(githubVersion)) {
8896
case -1:
@@ -95,7 +103,7 @@ public CheckResult check() {
95103
return null;
96104
}
97105

98-
} catch (IOException e) {
106+
} catch (IOException | URISyntaxException e) {
99107
e.printStackTrace();
100108
}
101109
return null;

src/test/java/com/lezurex/githubversionchecker/GithubVersionCheckerTest.java

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,30 @@ class GithubVersionCheckerTest {
1313
void setupValidRepo() {
1414
ReleaseVersion releaseVersion = new ReleaseVersion("0.1.1");
1515
assertDoesNotThrow(() -> {
16-
GithubVersionChecker versionChecker = new GithubVersionChecker("Lezurex", "github-version-checker", releaseVersion);
16+
new GithubVersionChecker("Lezurex", "github-version-checker", releaseVersion);
1717
}, "Repo validation failed!");
1818
}
1919

2020
@Test
2121
@DisplayName("Setup with invalid repo")
2222
void setupInvalidRepo() {
2323
ReleaseVersion releaseVersion = new ReleaseVersion("0.1.1");
24-
assertThrows(RepoNotFoundException.class, () -> new GithubVersionChecker("Lezurex", "doesnotexist", releaseVersion), "Repo validation di not fail!");
24+
assertThrows(RepoNotFoundException.class,
25+
() -> new GithubVersionChecker("Lezurex", "doesnotexist", releaseVersion),
26+
"Repo validation di not fail!");
2527
}
2628

2729
@Test
2830
@DisplayName("Check with outdated version")
2931
void checkOutdated() {
3032
ReleaseVersion releaseVersion = new ReleaseVersion("0.0.1");
31-
GithubVersionChecker githubVersionChecker = new GithubVersionChecker("VoxCrafterLP", "JumpRace", releaseVersion);
33+
GithubVersionChecker githubVersionChecker =
34+
new GithubVersionChecker("VoxCrafterLP", "JumpRace", releaseVersion);
3235
CheckResult checkResult = githubVersionChecker.check();
33-
assertEquals(VersionState.OUTDATED, checkResult.getVersionState(), "Version state is not outdated!");
34-
assertTrue(checkResult.getPageLink().endsWith(checkResult.getVersion().toString()), "End of release URL does not match version!");
36+
assertEquals(VersionState.OUTDATED, checkResult.getVersionState(),
37+
"Version state is not outdated!");
38+
assertTrue(checkResult.getPageLink().endsWith(checkResult.getVersion().toString()),
39+
"End of release URL does not match version!");
3540
}
3641

37-
}
42+
}

0 commit comments

Comments
 (0)