Bugfix/ensemble libe specs attrs passthrough (#1264)

* it turns out that values set by validators are still considered "unset". So for updating purposes for libE_specs, we want to exclude fields that are still set to their defaults

* starting to create unit test

* finish up unit test

* platform_specs sometimes seems to be at risk of disappearing when we convert LibeSpecs to dict, so lets save it and reinsert

Author: jlnav

libensemble/ensemble.py

@@ -326,8 +326,14 @@ def libE_specs(self, new_specs):
             return
 
         # Cast new libE_specs temporarily to dict
-        if not isinstance(new_specs, dict):
-            new_specs = specs_dump(new_specs, by_alias=True, exclude_none=True, exclude_unset=True)
+        if not isinstance(new_specs, dict):  # exclude_defaults should only be enabled with Pydantic v2
+            platform_specs_set = False
+            if new_specs.platform_specs != {}:  # bugginess across Pydantic versions for recursively casting to dict
+                platform_specs_set = True
+                platform_specs = new_specs.platform_specs
+            new_specs = specs_dump(new_specs, exclude_none=True, exclude_defaults=True)
+            if platform_specs_set:
+                new_specs["platform_specs"] = specs_dump(platform_specs, exclude_none=True)
 
         # Unset "comms" if we already have a libE_specs that contains that field, that came from parse_args
         if new_specs.get("comms") and hasattr(self._libE_specs, "comms") and self.parsed:

libensemble/tests/unit_tests/test_ensemble.py

@@ -166,10 +166,35 @@ def test_flakey_workflow():
     assert not flag, "should've caught input errors"
 
 
+def test_ensemble_specs_update_libE_specs():
+    """Test that libE_specs is updated as expected with .attribute setting"""
+    from libensemble.ensemble import Ensemble
+    from libensemble.resources.platforms import PerlmutterGPU
+    from libensemble.specs import LibeSpecs
+
+    platform_specs = PerlmutterGPU()
+
+    ensemble = Ensemble(
+        libE_specs=LibeSpecs(comms="local", nworkers=4),
+    )
+
+    ensemble.libE_specs = LibeSpecs(
+        num_resource_sets=ensemble.nworkers - 1,
+        resource_info={"gpus_on_node": 4},
+        use_workflow_dir=True,
+        platform_specs=platform_specs,
+    )
+
+    assert ensemble.libE_specs.num_resource_sets == ensemble.nworkers - 1
+    assert len(str(ensemble.libE_specs.workflow_dir_path)) > 1
+    assert ensemble.libE_specs.platform_specs == specs_dump(platform_specs, exclude_none=True)
+
+
 if __name__ == "__main__":
     test_ensemble_init()
     test_ensemble_parse_args_false()
     test_from_files()
     test_bad_func_loads()
     test_full_workflow()
     test_flakey_workflow()
+    test_ensemble_specs_update_libE_specs()