Skip to content

Commit c9a7918

Browse files
committed
Don’t use mutable object as a default parameter
`def foo(bar=[]):` is dangerous because the list will be initialized once and the state will be shared across future calls.
1 parent c345ed3 commit c9a7918

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

bagit.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,10 @@ class BagError(Exception):
553553

554554

555555
class BagValidationError(BagError):
556-
def __init__(self, message, details=[]):
556+
def __init__(self, message, details=None):
557+
if details is None:
558+
details = []
559+
557560
self.message = message
558561
self.details = details
559562

0 commit comments

Comments
 (0)