Skip to content

Commit 84523e3

Browse files
committed
fix: prevent issues
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent ad942f0 commit 84523e3

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

lib/Handler/CertificateEngine/OrderCertificatesTrait.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@ private function buildChain(array $certificates): array {
4646

4747
private function ensureValidStructure(array $certificates): void {
4848
foreach ($certificates as $cert) {
49-
if (!is_array($cert) || !isset($cert['subject'], $cert['issuer'], $cert['name'])
50-
|| !is_array($cert['subject']) || !is_array($cert['issuer'])) {
49+
if (!is_array($cert) || !isset($cert['subject'], $cert['issuer'], $cert['name'])) {
50+
throw new InvalidArgumentException('Invalid certificate structure. Certificate must have "subject", "issuer", and "name".');
51+
}
52+
if (!is_array($cert['subject']) || !is_array($cert['issuer'])) {
5153
throw new InvalidArgumentException('Invalid certificate structure. Certificate must have "subject", "issuer", and "name".');
5254
}
5355
}

lib/Handler/SignEngine/Pkcs12Handler.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ private function enrichLeafWithPopplerData(array &$result, array $fromFallback):
164164
}
165165
}
166166

167-
if (isset($popplerData['signature_validation'])) {
167+
if (isset($popplerData['signature_validation']) &&
168+
(!isset($leafCert['signature_validation']) || $leafCert['signature_validation']['id'] !== 1)) {
168169
$leafCert['signature_validation'] = $popplerData['signature_validation'];
169170
}
170171
}

0 commit comments

Comments
 (0)