chore: change scale factor

This will reduce the size of files at server and also the final size of
PDF files

Signed-off-by: Vitor Mattos <vitor@php.rio>

Author: vitormattos

lib/Service/SignatureBackgroundService.php

@@ -25,6 +25,7 @@
 
 class SignatureBackgroundService {
 	use TSimpleFile;
+	public const SCALE_FACTOR = 3;
 
 	public function __construct(
 		private IAppData $appData,
@@ -86,10 +87,8 @@ private function scaleDimensions(int $width, int $height): array {
 		$signatureWidth = $this->appConfig->getValueFloat(Application::APP_ID, 'signature_width', SignatureTextService::DEFAULT_SIGNATURE_WIDTH);
 		$signatureHeight = $this->appConfig->getValueFloat(Application::APP_ID, 'signature_height', SignatureTextService::DEFAULT_SIGNATURE_HEIGHT);
 
-		$upscaleFactor = 5;
-
-		$maxWidth = $signatureWidth * $upscaleFactor;
-		$maxHeight = $signatureHeight * $upscaleFactor;
+		$maxWidth = $signatureWidth * self::SCALE_FACTOR;
+		$maxHeight = $signatureHeight * self::SCALE_FACTOR;
 
 		if ($width <= $maxWidth && $height <= $maxHeight) {
 			return ['width' => $width, 'height' => $height];

tests/Unit/Service/SignatureBackgroundServiceTest.php

@@ -63,13 +63,13 @@ public static function providerScaleDimensions(): array {
 			'under limit => return equals' =>
 				[100, 50, 200, 100, 100, 50],
 			'between upscale limit => return equals' =>
-				[900, 400, 200, 100, 900, 400],
+				[500, 200, 200, 100, 500, 200],
 			'height over upscale limit => reduce to scale limit' =>
-				[1200, 800, 200, 100, 750, 500],
+				[800, 600, 200, 100, 400, 300],
 			'width and height over upscale limit => reduce to scale limit' =>
-				[2000, 1600, 200, 100, 625, 500],
+				[2000, 1600, 200, 100, 375, 300],
 			'every return integer' =>
-				[2000, 1600, 200.7, 100.5, 628, 502],
+				[2000, 1600, 200.7, 100.5, 376, 301],
 		];
 	}
 }