fix: make possible to test with dates

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

lib/Service/ReminderService.php

@@ -136,15 +136,14 @@ protected function scheduleJob(string $startTime): ?DateTime {
 	protected function getStartTime(string $startTime): ?\DateTime {
 		$timezone = $this->dateTimeZone->getTimeZone();
 
-		$dateTime = new \DateTime($startTime, $timezone);
-		$dateTime->setTimezone(new \DateTimeZone('UTC'));
-
-		$now = new \DateTime('now', new \DateTimeZone('UTC'));
-		if ($dateTime > $now) {
-			return $dateTime;
-		}
+		$now = $this->time->getDateTime('now', new \DateTimeZone('UTC'));
+		$dateTime = clone $now;
 		$dateTime->modify('+1 day');
 
+		$time = new \DateTime($startTime, $timezone);
+		$dateTime->setTime((int)$time->format('H'), (int)$time->format('i'));
+		$dateTime->setTimezone(new \DateTimeZone('UTC'));
+
 		return $dateTime;
 	}
 

tests/php/Unit/Service/ReminderServiceTest.php

@@ -23,15 +23,15 @@ final class ReminderServiceTest extends \OCA\Libresign\Tests\Unit\TestCase {
 	protected IJobList|MockObject $jobList;
 	protected IAppConfig $appConfig;
 	protected IDateTimeZone $dateTimeZone;
-	protected ITimeFactory $time;
+	protected ITimeFactory|MockObject $time;
 	protected SignRequestMapper|MockObject $signRequestMapper;
 	protected IdentifyMethodService|MockObject $identifyMethodService;
 
 	public function setUp(): void {
 		$this->jobList = $this->createMock(IJobList::class);
 		$this->appConfig = $this->getMockAppConfig();
 		$this->dateTimeZone = Server::get(IDateTimeZone::class);
-		$this->time = Server::get(ITimeFactory::class);
+		$this->time = $this->createMock(ITimeFactory::class);
 		$this->signRequestMapper = $this->createMock(SignRequestMapper::class);
 		$this->identifyMethodService = $this->createMock(IdentifyMethodService::class);
 	}
@@ -105,7 +105,7 @@ public function testWillNotify(array $summarized, \DateTime $now, int $daysBefor
 	}
 
 	public static function providerWillNotify(): array {
-		$now = (new DateTime())->setTime(12, 0);
+		$now = new DateTime('2025-10-09 12:00:00', new \DateTimeZone('UTC'));
 
 		return [
 			'no notifications, should not send with all zero and null' => [
@@ -327,6 +327,11 @@ public function testSave(
 		string $sendTimer,
 		array $expected,
 	): void {
+		// Setup fixed time for consistent testing
+		$fixedTime = new DateTime('2025-10-09 09:00:00', new \DateTimeZone('UTC'));
+		$this->time->method('getDateTime')
+			->willReturn($fixedTime);
+
 		$service = $this->getService();
 		$actual = $service->save($daysBefore, $daysBetween, $max, $sendTimer);
 		$this->assertEquals($expected, $actual);
@@ -347,7 +352,7 @@ public function testSave(
 	}
 
 	public static function providerSave(): array {
-		$now = (new DateTime());
+		$now = (new DateTime('2025-10-09 09:00:00', new \DateTimeZone('UTC')));
 		return [
 			[
 				'daysBefore' => 0, 'daysBetween' => 0, 'max' => 0, 'sendTimer' => '',