fix: make the error message more specific

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

lib/Service/IdentifyMethod/SignatureMethod/EmailToken.php

@@ -9,7 +9,6 @@
 namespace OCA\Libresign\Service\IdentifyMethod\SignatureMethod;
 
 use OCA\Libresign\Exception\LibresignException;
-use OCA\Libresign\Helper\JSActions;
 use OCA\Libresign\Service\IdentifyMethod\IdentifyService;
 use OCA\Libresign\Vendor\Wobeto\EmailBlur\Blur;
 
@@ -42,10 +41,15 @@ public function toArray(): array {
 		};
 
 		if (!filter_var($email, FILTER_VALIDATE_EMAIL)) {
-			throw new LibresignException(json_encode([
-				'action' => JSActions::ACTION_DO_NOTHING,
-				'errors' => [['message' => $this->identifyService->getL10n()->t('Invalid email')]],
-			]));
+			$message = match ($entity->getIdentifierKey()) {
+				// TRANSLATORS Error message shown when the email provided is not valid
+				'email' => $this->identifyService->getL10n()->t('Invalid email'),
+				// TRANSLATORS Error message shown when the signer has no valid email address in his profile, so he cannot be identified by email token
+				'account' => $this->identifyService->getL10n()->t('Signer without valid email address to be identified by email token.'),
+				// TRANSLATORS Error message shown when the email provided is not valid
+				default => $this->identifyService->getL10n()->t('Invalid email'),
+			};
+			throw new LibresignException($message);
 		}
 
 		$emailLowercase = strtolower($email);

tests/php/Unit/Service/IdentifyMethod/SignatureMethod/EmailTokenTest.php

@@ -42,18 +42,14 @@ private function getClass(): EmailToken {
 	}
 
 	#[DataProvider('providerToArrayWithInvalidEmail')]
-	public function testToArrayWithInvalidEmail(mixed $email): void {
+	public function testToArrayWithInvalidEmail(string $email): void {
 		$instance = $this->getClass();
 		$identifyMethod = new IdentifyMethod();
 		$identifyMethod->fromRow([
 			'identifierValue' => $email
 		]);
 		$instance->setEntity($identifyMethod);
 		$this->expectException(LibresignException::class);
-		$this->expectExceptionMessage(json_encode([
-			'action' => 2000,
-			'errors' => [['message' => 'Invalid email']],
-		]));
 		$instance->toArray();
 	}