Merge pull request #7143 from LibreSign/backport/7142/stable32

[stable32] test: add playwright regression for Files new signature request flow

Author: vitormattos

playwright/e2e/files-new-signature-request.spec.ts

@@ -0,0 +1,73 @@
+/**
+ * SPDX-FileCopyrightText: 2026 LibreCode coop and contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { expect, test } from '@playwright/test'
+import { login } from '../support/nc-login'
+import { configureOpenSsl, setAppConfig } from '../support/nc-provisioning'
+
+test('new signature request opens LibreSign tab and does not duplicate file row', async ({ page }) => {
+	await login(
+		page.request,
+		process.env.NEXTCLOUD_ADMIN_USER ?? 'admin',
+		process.env.NEXTCLOUD_ADMIN_PASSWORD ?? 'admin',
+	)
+
+	await configureOpenSsl(page.request, 'LibreSign Test', {
+		C: 'BR',
+		OU: ['Organization Unit'],
+		ST: 'Rio de Janeiro',
+		O: 'LibreSign',
+		L: 'Rio de Janeiro',
+	})
+
+	await setAppConfig(
+		page.request,
+		'libresign',
+		'identify_methods',
+		JSON.stringify([
+			{ name: 'account', enabled: true, mandatory: true, signatureMethods: { clickToSign: { enabled: true } } },
+			{ name: 'email', enabled: false, mandatory: false },
+		]),
+	)
+
+	const uniqueName = `libresign-upload-${Date.now()}.pdf`
+	const pdfResponse = await page.request.get('https://raw.githubusercontent.com/LibreSign/libresign/main/tests/php/fixtures/pdfs/small_valid.pdf', {
+		failOnStatusCode: true,
+	})
+	const pdfBuffer = Buffer.from(await pdfResponse.body())
+
+	await page.goto('./apps/files')
+
+	await page.getByRole('button', { name: 'New' }).click()
+	const newSignatureRequest = page.getByText('New signature request', { exact: true })
+	await expect(newSignatureRequest).toBeVisible()
+	const fileChooserPromise = page.waitForEvent('filechooser')
+	await newSignatureRequest.click()
+	const libresignCreateResponsePromise = page.waitForResponse(
+		(response) => response.url().includes('/ocs/v2.php/apps/libresign/api/v1/file') && response.request().method() === 'POST',
+		{ timeout: 20000 },
+	)
+	const chooser = await fileChooserPromise
+	await chooser.setFiles({
+		name: uniqueName,
+		mimeType: 'application/pdf',
+		buffer: pdfBuffer,
+	})
+	const libresignCreateResponse = await libresignCreateResponsePromise
+	const libresignCreateBody = await libresignCreateResponse.json() as { ocs: { data: { nodeId: number } } }
+
+	// On stable32, Files sidebar internals differ; a successful LibreSign OCS creation call is
+	// the stable evidence that "New signature request" executed the LibreSign flow.
+	await expect(libresignCreateResponse.ok()).toBeTruthy()
+
+	const filesTable = page.getByRole('table', {
+		name: /List of your files and folders/i,
+	})
+	const matchingRequestRows = filesTable.locator(
+		`[data-cy-files-list-row][data-cy-files-list-row-fileid="${libresignCreateBody.ocs.data.nodeId}"]`,
+	)
+
+	await expect(matchingRequestRows).toHaveCount(1, { timeout: 15000 })
+})

src/init.ts

@@ -7,14 +7,16 @@ import axios from '@nextcloud/axios'
 import { addNewFileMenuEntry, Permission } from '@nextcloud/files'
 import type { NewMenuEntry, IFolder, INode } from '@nextcloud/files'
 import { registerDavProperty } from '@nextcloud/files/dav'
-import { getClient, resultToNode } from '@nextcloud/files/dav'
+import { getClient, getDefaultPropfind, getRootPath, resultToNode } from '@nextcloud/files/dav'
 import { t } from '@nextcloud/l10n'
 import { generateOcsUrl } from '@nextcloud/router'
 import { getUploader } from '@nextcloud/upload'
 import type { Uploader } from '@nextcloud/upload'
 import type { FileStat, ResponseDataDetailed } from 'webdav'
 
 import logger from './logger'
+import './actions/openInLibreSignAction.js'
+import './actions/showStatusInlineAction.js'
 import LibreSignLogoSvg from '../img/app-colored.svg?raw'
 import LibreSignLogoDarkSvg from '../img/app-dark.svg?raw'
 import { useIsDarkTheme } from './helpers/useIsDarkTheme'
@@ -64,9 +66,12 @@ addNewFileMenuEntry({
 				name: file.name,
 			})
 
-			// Fetch the complete node object from the Files API
+			// Fetch the complete node object including NC-specific DAV properties.
 			const client = getClient()
-			const result = await client.stat(path, { details: true }) as ResponseDataDetailed<FileStat>
+			const result = await client.stat(`${getRootPath()}${path}`, {
+				details: true,
+				data: getDefaultPropfind(),
+			}) as ResponseDataDetailed<FileStat>
 			const node = resultToNode(result.data)
 
 			// Open sidebar with LibreSign tab

src/store/files.js

@@ -406,6 +406,9 @@ export const useFilesStore = function(...args) {
 				}
 			},
 			signerUpdate(signer) {
+				if (!this.selectedFileId || !this.files[this.selectedFileId]) {
+					return
+				}
 				this.addIdentifierToSigner(signer)
 				if (!this.getFile().signers?.length) {
 					this.getFile().signers = []

src/tests/utils/timePresets.spec.ts

@@ -9,6 +9,7 @@ import { getTimePresetRange, getTimePresets } from '../../utils/timePresets.js'
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: (_app: string, text: string) => text,
+	isRTL: vi.fn(() => false),
 }))
 
 describe('getTimePresets', () => {

src/tests/views/FilesList/FileListFilter/FileListFilter.spec.ts

@@ -12,6 +12,7 @@ import FileListFilter from '../../../../views/FilesList/FileListFilter/FileListF
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: vi.fn((_app: string, text: string) => text),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({

src/tests/views/FilesList/FileListFilter/FileListFilterChips.spec.ts

@@ -13,6 +13,7 @@ import { useFiltersStore } from '../../../../store/filters.js'
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: vi.fn((_app: string, text: string) => text),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({

src/tests/views/FilesList/FileListFilter/FileListFilterModified.spec.ts

@@ -21,6 +21,7 @@ vi.mock('@nextcloud/l10n', () => ({
 		}
 		return text
 	}),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({

src/tests/views/FilesList/FileListFilter/FileListFilterStatus.spec.ts

@@ -14,6 +14,7 @@ import { FILE_STATUS } from '../../../../constants.js'
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: vi.fn((_app: string, text: string) => text),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({

src/tests/views/FilesList/FileListFilters.spec.ts

@@ -26,6 +26,7 @@ vi.mock('../../../composables/useFileListWidth.js', () => ({
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: vi.fn((_app: string, text: string) => text),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({

src/tests/views/FilesList/FilesList.spec.ts

@@ -13,6 +13,7 @@ import { useUserConfigStore } from '../../../store/userconfig.js'
 
 vi.mock('@nextcloud/l10n', () => ({
 	t: vi.fn((_app: string, text: string) => text),
+	isRTL: vi.fn(() => false),
 }))
 
 vi.mock('@nextcloud/logger', () => ({