Skip to content

Commit b41bb04

Browse files
committed
chore: resolve code review comment
Solve #5459 (comment) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
1 parent 49e3bb2 commit b41bb04

3 files changed

Lines changed: 8 additions & 8 deletions

File tree

lib/Service/IdentifyMethod/SignatureMethod/EmailToken.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,14 @@ private function blurEmail(string $email): string {
7171
return $blur->make();
7272
}
7373

74-
public function requestCode(string $identify, string $method): void {
74+
public function requestCode(string $identifier, string $method): void {
7575
$signRequestMapper = $this->identifyService->getSignRequestMapper();
7676
$signRequest = $signRequestMapper->getById($this->getEntity()->getSignRequestId());
7777
$displayName = $signRequest->getDisplayName();
78-
if ($identify === $displayName) {
78+
if ($identifier === $displayName) {
7979
$displayName = '';
8080
}
81-
$code = $this->tokenService->sendCodeByEmail($identify, $displayName);
81+
$code = $this->tokenService->sendCodeByEmail($identifier, $displayName);
8282
$this->getEntity()->setCode($code);
8383
$this->identifyService->save($this->getEntity());
8484
}

lib/Service/IdentifyMethod/SignatureMethod/IToken.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
namespace OCA\Libresign\Service\IdentifyMethod\SignatureMethod;
1010

1111
interface IToken {
12-
public function requestCode(string $identify, string $method): void;
12+
public function requestCode(string $identifier, string $method): void;
1313
}

lib/Service/IdentifyMethod/SignatureMethod/TwofactorGatewayToken.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,17 @@ private function blurIdentifier(string $identifier, int $visibleStart = 2, int $
6767
return $start . str_repeat('*', $maskedLength) . $end;
6868
}
6969

70-
public function requestCode(string $identify, string $method): void {
70+
public function requestCode(string $identifier, string $method): void {
7171
$signRequestMapper = $this->identifyService->getSignRequestMapper();
7272
$signRequest = $signRequestMapper->getById($this->getEntity()->getSignRequestId());
7373
$displayName = $signRequest->getDisplayName();
74-
if ($identify === $displayName) {
74+
if ($identifier === $displayName) {
7575
$displayName = '';
7676
}
7777
if ($method === 'email') {
78-
$code = $this->tokenService->sendCodeByEmail($identify, $displayName);
78+
$code = $this->tokenService->sendCodeByEmail($identifier, $displayName);
7979
} else {
80-
$code = $this->tokenService->sendCodeByGateway($identify, $method);
80+
$code = $this->tokenService->sendCodeByGateway($identifier, $method);
8181
}
8282
$this->getEntity()->setCode($code);
8383
$this->identifyService->save($this->getEntity());

0 commit comments

Comments
 (0)