test(policy): cover explicit signature flow default persistence

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

tests/php/Unit/Service/Policy/Runtime/PolicySourceTest.php

@@ -63,7 +63,7 @@ public function testLoadSystemPolicyReturnsForcedLayerWhenAppConfigIsSet(): void
 		$layer = $source->loadSystemPolicy('signature_flow');
 
 		$this->assertNotNull($layer);
-		$this->assertSame('system', $layer->getScope());
+		$this->assertSame('global', $layer->getScope());
 		$this->assertSame('ordered_numeric', $layer->getValue());
 		$this->assertFalse($layer->isAllowChildOverride());
 		$this->assertSame(['ordered_numeric'], $layer->getAllowedValues());
@@ -82,6 +82,7 @@ public function testLoadSystemPolicyReturnsInheritableLayerWhenAppConfigMatchesD
 
 		$this->assertNotNull($layer);
 		$this->assertSame('none', $layer->getValue());
+		$this->assertSame('system', $layer->getScope());
 		$this->assertTrue($layer->isAllowChildOverride());
 		$this->assertSame([], $layer->getAllowedValues());
 	}
@@ -180,6 +181,29 @@ public function testSaveSystemPolicyDeletesAppConfigWhenValueMatchesDefault(): v
 		$this->assertSame(['policy.signature_flow.system', 'policy.signature_flow.system.allow_child_override'], $deletedKeys);
 	}
 
+	public function testSaveSystemPolicyPersistsExplicitDefaultWhenAllowChildOverrideIsTrue(): void {
+		$savedValues = [];
+		$this->appConfig
+			->expects($this->exactly(2))
+			->method('setAppValueString')
+			->willReturnCallback(static function (string $key, string $value) use (&$savedValues): bool {
+				$savedValues[$key] = $value;
+				return true;
+			});
+
+		$this->appConfig
+			->expects($this->never())
+			->method('deleteAppValue');
+
+		$source = $this->getSource();
+		$source->saveSystemPolicy('signature_flow', 'none', true);
+
+		$this->assertSame([
+			'policy.signature_flow.system' => 'none',
+			'policy.signature_flow.system.allow_child_override' => '1',
+		], $savedValues);
+	}
+
 	public function testSaveSystemPolicyNormalizesAndPersistsAppConfigValue(): void {
 		$savedValues = [];
 		$this->appConfig
@@ -222,11 +246,38 @@ public function testLoadSystemPolicyRespectsPersistedAllowChildOverride(): void
 
 		$this->assertNotNull($layer);
 		$this->assertSame('ordered_numeric', $layer->getValue());
+		$this->assertSame('global', $layer->getScope());
 		$this->assertTrue($layer->isAllowChildOverride());
 		$this->assertSame([], $layer->getAllowedValues());
 		$this->assertSame(2, $calls);
 	}
 
+	public function testLoadSystemPolicyTreatsPersistedDefaultAsExplicitWhenAllowChildOverrideIsSet(): void {
+		$this->appConfig
+			->expects($this->exactly(2))
+			->method('getAppValueString')
+			->willReturnCallback(static function (string $key, string $default): string {
+				if ($key === 'policy.signature_flow.system' && $default === '') {
+					return 'none';
+				}
+
+				if ($key === 'policy.signature_flow.system.allow_child_override' && $default === '0') {
+					return '1';
+				}
+
+				throw new \RuntimeException('Unexpected app config key request: ' . $key);
+			});
+
+		$source = $this->getSource();
+		$layer = $source->loadSystemPolicy('signature_flow');
+
+		$this->assertNotNull($layer);
+		$this->assertSame('none', $layer->getValue());
+		$this->assertSame('global', $layer->getScope());
+		$this->assertTrue($layer->isAllowChildOverride());
+		$this->assertSame([], $layer->getAllowedValues());
+	}
+
 	public function testLoadGroupPolicyConfigReturnsBoundPolicyLayer(): void {
 		$binding = new PermissionSetBinding();
 		$binding->setPermissionSetId(77);