test: cover legacy identify methods config

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

tests/php/Unit/Service/IdentifyMethod/IdentifyServiceTest.php

@@ -21,6 +21,7 @@
 use OCA\Libresign\Tests\Unit\TestCase;
 use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\EventDispatcher\IEventDispatcher;
+use OCP\Exceptions\AppConfigTypeConflictException;
 use OCP\Files\IRootFolder;
 use OCP\IAppConfig;
 use OCP\IL10N;
@@ -156,6 +157,11 @@ public function testPropagateIdentifiedDateSkipsCurrentRequestAndUpdatesSiblings
 	}
 
 	public function testGetSavedSettingsFallsBackToDefaultWhenStoredValueIsInvalid(): void {
+		$this->appConfig
+			->expects($this->once())
+			->method('clearCache')
+			->with(true);
+
 		$this->appConfig
 			->expects($this->once())
 			->method('getValueArray')
@@ -174,4 +180,82 @@ public function testGetSavedSettingsFallsBackToDefaultWhenStoredValueIsInvalid()
 
 		$this->assertSame([], $this->service->getSavedSettings());
 	}
+
+	public function testGetSavedSettingsDecodesLegacyJsonStringWhenStoredValueTypeConflicts(): void {
+		$this->appConfig
+			->expects($this->once())
+			->method('clearCache')
+			->with(true);
+
+		$this->appConfig
+			->expects($this->once())
+			->method('getValueArray')
+			->with(Application::APP_ID, 'identify_methods', [])
+			->willThrowException(new AppConfigTypeConflictException('conflict with value type from database'));
+
+		$this->appConfig
+			->expects($this->once())
+			->method('getValueString')
+			->with(Application::APP_ID, 'identify_methods', '')
+			->willReturn('[{"name":"account","enabled":true}]');
+
+		$this->logger
+			->expects($this->never())
+			->method('warning');
+
+		$this->assertSame([
+			[
+				'name' => 'account',
+				'enabled' => true,
+			],
+		], $this->service->getSavedSettings());
+	}
+
+	public function testGetSavedSettingsFallsBackToDefaultWhenLegacyStringIsInvalid(): void {
+		$this->appConfig
+			->expects($this->once())
+			->method('clearCache')
+			->with(true);
+
+		$this->appConfig
+			->expects($this->once())
+			->method('getValueArray')
+			->with(Application::APP_ID, 'identify_methods', [])
+			->willThrowException(new AppConfigTypeConflictException('conflict with value type from database'));
+
+		$this->appConfig
+			->expects($this->once())
+			->method('getValueString')
+			->with(Application::APP_ID, 'identify_methods', '')
+			->willReturn('invalid');
+
+		$this->logger
+			->expects($this->once())
+			->method('warning')
+			->with(
+				'Invalid identify_methods app config; falling back to defaults.',
+				$this->callback(static function (array $context): bool {
+					return isset($context['exception']) && $context['exception'] instanceof AppConfigTypeConflictException;
+				})
+			);
+
+		$this->assertSame([], $this->service->getSavedSettings());
+	}
+
+	public function testGetSavedSettingsReloadsAppConfigBeforeReading(): void {
+		$expected = [['name' => 'account', 'enabled' => true]];
+
+		$this->appConfig
+			->expects($this->once())
+			->method('clearCache')
+			->with(true);
+
+		$this->appConfig
+			->expects($this->once())
+			->method('getValueArray')
+			->with(Application::APP_ID, 'identify_methods', [])
+			->willReturn($expected);
+
+		$this->assertSame($expected, $this->service->getSavedSettings());
+	}
 }