fix(lndhub): default limit=200 for getuserinvoices and gettxs#196
Merged
Conversation
App sends no limit to getuserinvoices, causing LNBits to default to 20. With probe payments mixed in, users see far fewer real transactions than expected. Setting a server-side default of 200 (LNBits max) ensures full history is returned without requiring a wallet release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getuserinvoicesandgettxsnow default tolimit=200(LNBits max) when the caller sends no limitlimitparam — the default only applies when absentgetuserinvoices, LNBits defaulted to 20, probe payments consumed most slots leaving few real transactions visibleTest plan
limitstill works (e.g.?limit=10returns 10)gettxs(outgoing payments)