Skip to content

Commit 244fbc9

Browse files
author
Gaurav SinghaRoy
committed
making sure the loading image closes even in cases of error in class select histogram
1 parent 60957e2 commit 244fbc9

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

app/assets/javascripts/resources/querybuilder.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ QueryBuilder = {
167167
add_class_details : function(element,class_uri,tab_level){
168168
element.attr('class-uri',class_uri);
169169
element.find('strong').first().after("<span class='loading-image'>&nbsp;&nbsp;&nbsp;<img height=\"10px\" src=\"/assets/horizontal-loading.gif\"></span>");
170-
$.getJSON(QueryBuilder.classes.get_examples_action_url(class_uri),function(data){
170+
$.getJSON(QueryBuilder.classes.get_examples_action_url(class_uri)).success(function(data){
171171
var element_append_html = "&nbsp;&nbsp;&nbsp;<span class='badge'>"+data.total_objects.toString()+"</span>";
172172
if(data.total_objects > 0){
173173
element_append_html += "&nbsp;&nbsp;<small>(&nbsp;";
@@ -178,8 +178,10 @@ QueryBuilder = {
178178
}
179179
element_append_html += "&nbsp;)</small>";
180180
}
181-
element.find(".loading-image").first().remove();
181+
//element.find(".loading-image").first().remove();
182182
element.find("strong").after(element_append_html);
183+
}).always(function(){
184+
element.find(".loading-image").first().remove();
183185
});
184186
QueryBuilder.classes.add_subclasses_details(element,class_uri,tab_level);
185187
},

0 commit comments

Comments
 (0)