Fixes more warnings for possible string truncation

This commit changes strncpy() for snprintf(), snprintf() guarantees a
NULL terminating string.

These places did not check the length at all, some hard-coded a NULL
terminating string as the last place in the array. With this, some of
the strings could potentially be without the NULL terminating character.

By changing to snprintf() we run into the possibility of truncating the
strings, no checks is currently in place to catch this.

There is also a strncat() thrown on here, hard-coded value was changed
from 1 to 2 to make room for the NULL terminating character.

Author: havardAasen

src/emc/rs274ngc/interp_namedparams.cc

@@ -217,8 +217,7 @@ int Interp::fetch_ini_param( const char *nameBuf, int *status, double *value)
 
 	char capName[LINELEN];
 
-	strncpy(capName, nameBuf, n);
-	capName[n] = '\0';
+	snprintf(capName, LINELEN, "%s", nameBuf);
 	for (char *p = capName; *p != 0; p++)
 	    *p = toupper(*p);
 	capName[closeBracket] = '\0';

src/emc/rs274ngc/interp_remap.cc

@@ -294,7 +294,7 @@ int Interp::add_parameters(setup_pointer settings,
     while (*s) {
 	errored = true;
 	char c  = toupper(*s);
-	strncat(tail,&c,1);
+	strncat(tail,&c,2);
 	if (*(s+1)) rtapi_strxcat(tail,",");
 	s++;
     }

src/emc/task/emctaskmain.cc

@@ -284,8 +284,7 @@ static int argvize(const char *src, char *dst, char *argv[], int len)
     char inquote;
     char looking;
 
-    strncpy(dst, src, len);
-    dst[len - 1] = 0;
+    snprintf(dst, len, "%s", src);
     bufptr = dst;
     inquote = 0;
     argvix = 0;

src/hal/utils/halcmd_commands.cc

@@ -1221,8 +1221,7 @@ int do_delsig_cmd(char *mod_name)
 	    sig = SHMPTR(next);
 	    /* we want to unload this signal, remember its name */
 	    if ( n < ( MAX_EXPECTED_SIGS - 1 ) ) {
-	        strncpy(sigs[n], sig->name, HAL_NAME_LEN );
-		sigs[n][HAL_NAME_LEN] = '\0';
+		snprintf(sigs[n], sizeof(sigs[n]), "%s", sig->name);
 		n++;
 	    }
 	    next = sig->next_ptr;
@@ -1315,8 +1314,7 @@ int do_unloadrt_cmd(char *mod_name)
 	    if ( all || ( strcmp(mod_name, comp->name) == 0 )) {
 		/* we want to unload this component, remember its name */
 		if ( n < 63 ) {
-		    strncpy(comps[n], comp->name, HAL_NAME_LEN );
-		    comps[n][HAL_NAME_LEN] = '\0';
+		    snprintf(comps[n], sizeof(comps[n]), "%s", comp->name);
 		    n++;
 		}
 	    }

src/hal/utils/halrmt.c

@@ -1262,8 +1262,7 @@ static int doDelsig(char *mod_name, connectionRecType *context)
         sig = SHMPTR(next);
         /* we want to unload this signal, remember it's name */
         if (n < ( MAX_EXPECTED_SIGS - 1)) {
-          strncpy(sigs[n], sig->name, HAL_NAME_LEN );
-	  sigs[n][HAL_NAME_LEN] = '\0';
+          snprintf(sigs[n], sizeof(sigs[n]), "%s", sig->name);
 	  n++;
 	  }
         next = sig->next_ptr;
@@ -1318,7 +1317,7 @@ static int doUnload(char *mod_name, connectionRecType *context)
 	    if ( all || ( strcmp(mod_name, comp->name) == 0 )) {
 		/* we want to unload this component, remember its name */
 		if ( n < 63 ) {
-		    strncpy(comps[n], comp->name, HAL_NAME_LEN );
+		    snprintf(comps[n], sizeof(comps[n]), "%s", comp->name);
 		    comps[n][HAL_NAME_LEN] = '\0';
 		    n++;
 		}

src/hal/utils/scope_vert.c

@@ -765,7 +765,7 @@ static void offset_changed(GtkEditable * editable, struct offset_data *data)
 
     /* maybe user typed something, save it in the buffer */
     text = gtk_entry_get_text(GTK_ENTRY(ctrl_usr->vert.offset_entry));
-    strncpy(data->buf, text, BUFLEN);
+    snprintf(data->buf, BUFLEN, "%s", text);
 }
 
 /*

src/libnml/nml/nml.cc

@@ -178,12 +178,12 @@ NML::NML(NML_FORMAT_PTR f_ptr, const char *buf, const char *proc, const char *fi
     blocking_read_poll_interval = -1.0;
     forced_type = 0;
 
-    strncpy(bufname, buf, 40);
-    strncpy(procname, proc, 40);
+    snprintf(bufname, 40, "%s", buf);
+    snprintf(procname, 40, "%s", proc);
     if (NULL == file) {
 	file = default_nml_config_file;
     }
-    strncpy(cfgfilename, file, 160);
+    snprintf(cfgfilename, 160, "%s", file);
 
     if (rcs_errors_printed >= max_rcs_errors_to_print
 	&& max_rcs_errors_to_print > 0 && nml_reset_errors_printed) {
@@ -344,9 +344,9 @@ NML::NML(const char *buf, const char *proc, const char *file, int set_to_server,
     }
     registered_with_server = 0;
     cms_for_msg_string_conversions = 0;
-    strncpy(bufname, buf, 40);
-    strncpy(procname, proc, 40);
-    strncpy(cfgfilename, file, 160);
+    snprintf(bufname, 40 , "%s", buf);
+    snprintf(procname, 40, "%s", proc);
+    snprintf(cfgfilename, 160, "%s", file);
     blocking_read_poll_interval = -1.0;
     info_printed = 0;
     forced_type = 0;
@@ -2132,9 +2132,9 @@ void NML::print_info(const char *bufname, const char *procname, const char *cfg_
 	    && !strncmp(cfg_file, last_cfg_file, 40)) {
 	    return;
 	}
-	strncpy(last_bufname, bufname, 10);
-	strncpy(last_procname, procname, 10);
-	strncpy(last_cfg_file, cfg_file, 40);
+	snprintf(last_bufname, 10, "%s", bufname);
+	snprintf(last_procname, 10, "%s", procname);
+	snprintf(last_cfg_file, 40, "%s", cfg_file);
     }
     if (!info_message_printed) {
 	rcs_print
@@ -2449,8 +2449,8 @@ void nmlSetHostAlias(const char *hostName, const char *hostAlias)
 	cmsHostAliases = new LinkedList;
     }
     CMS_HOST_ALIAS_ENTRY entry;
-    strncpy(entry.host, hostName, 64);
-    strncpy(entry.alias, hostAlias, 64);
+    snprintf(entry.host, 64, "%s", hostName);
+    snprintf(entry.alias, 64,  "%s", hostAlias);
     cmsHostAliases->store_at_tail(&entry, sizeof(entry), 1);
 }
 

src/libnml/nml/nml_mod.cc

@@ -818,7 +818,7 @@ NML_MODULE::write_status_out ()
   statusOutData->source_line = source_line;
   if (NULL != source_file)
     {
-      strncpy (statusOutData->source_file, source_file, 64);
+      snprintf(statusOutData->source_file, 64, "%s", source_file);
     }
 
   // write STATUS