Skip to content

Commit 8b88e0e

Browse files
committed
qtplasmac: fix matl overlay for locales that use a comma as a decimal
1 parent 0ae669a commit 8b88e0e

2 files changed

Lines changed: 18 additions & 10 deletions

File tree

share/qtvcp/screens/qtplasmac/qtplasmac_handler.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION = '237.307'
1+
VERSION = '237.308'
22
LCNCVER = '2.9'
33
DOCSVER = LCNCVER
44

@@ -743,6 +743,7 @@ def new_draw_grid(self):
743743
self.w.gcodegraphics.draw_grid_permuted(rotation, permutation,
744744
inverse_permutation)
745745

746+
746747
#########################################################################################################################
747748
# SPECIAL FUNCTIONS SECTION #
748749
#########################################################################################################################
@@ -1118,14 +1119,15 @@ def get_overlay_text(self):
11181119
else:
11191120
fr = 0
11201121
ou = 2
1121-
if '.' in self.w.cut_feed_rate.text() and len(self.w.cut_feed_rate.text().split('.')[0]) > 3:
1122-
text.append('FR: {:.{}f}'.format(float(self.w.cut_feed_rate.text().split('.')[0]) * scale, fr))
1122+
dp = '.' if '.' in self.w.pierce_height.text() else ','
1123+
if '.' in self.w.cut_feed_rate.text().replace(",", ".") and len(self.w.cut_feed_rate.text().replace(",", ".").split('.')[0]) > 3:
1124+
text.append(f'FR: {float(self.w.cut_feed_rate.text().replace(",", ".").split(".")[0]) * scale:.{fr}f}'.replace(".",dp))
11231125
else:
1124-
text.append('FR: {:.{}f}'.format(float(self.w.cut_feed_rate.text()) * scale, fr))
1125-
text.append('PH: {:.{}f}'.format(float(self.w.pierce_height.text()) * scale, ou))
1126-
text.append('PD: {}'.format(self.w.pierce_delay.text()))
1127-
text.append('CH: {:.{}f}'.format(float(self.w.cut_height.text()) * scale, ou))
1128-
text.append('KW: {:.{}f}'.format(float(self.w.kerf_width.text()) * scale, ou))
1126+
text.append(f'FR: {float(self.w.cut_feed_rate.text().replace(",", ".")) * scale:.{fr}f}'.replace(".",dp))
1127+
text.append(f'PH: {float(self.w.pierce_height.text().replace(",", ".")) * scale:.{ou}f}'.replace(".",dp))
1128+
text.append(f'PD: {self.w.pierce_delay.text()}')
1129+
text.append(f'CH: {float(self.w.cut_height.text().replace(",", ".")) * scale:.{ou}f}'.replace(".",dp))
1130+
text.append(f'KW: {float(self.w.kerf_width.text().replace(",", ".")) * scale:.{ou}f}'.replace(".",dp))
11291131
if self.pmx485Exists:
11301132
text.append('CA: {}'.format(self.w.cut_amps.text()))
11311133
return text
@@ -2010,6 +2012,7 @@ def backup_clicked(self):
20102012
lcncInfo = (Popen('linuxcnc_info -s', stdout=PIPE, stderr=PIPE, shell=True).communicate()[0]).decode('utf-8')
20112013
network = (Popen('lspci | grep -i net', stdout=PIPE, stderr=PIPE, shell=True).communicate()[0]).decode('utf-8')
20122014
with open(tmpFile, 'a') as outFile:
2015+
outFile.write(f'locale:\n{os.getenv("LANG")}\n\n')
20132016
if network:
20142017
outFile.write('lspci | grep -i net:\n{}\n'.format(network))
20152018
else:
@@ -4281,7 +4284,7 @@ def consumable_change_setup(self):
42814284
msg0 = _translate('HandlerClass', 'Invalid feed rate for consumable change')
42824285
msg1 = _translate('HandlerClass', 'Defaulting to materials cut feed rate')
42834286
STATUS.emit('update-machine-log', '{}, {}'.format(msg0, msg1), 'TIME')
4284-
self.ccFeed = float(self.w.cut_feed_rate.text())
4287+
self.ccFeed = float(self.w.cut_feed_rate.text().replace(',', '.'))
42854288

42864289
def ext_change_consumables(self, state):
42874290
if self.ccButton and self.w[self.ccButton].isEnabled():
@@ -4476,7 +4479,7 @@ def frame_job(self, state):
44764479
self.dialog_show_ok(QMessageBox.Warning, '{}'.format(head), '\n{}'.format(msgs))
44774480
return
44784481
if not self.frFeed:
4479-
feed = float(self.w.cut_feed_rate.text())
4482+
feed = float(self.w.cut_feed_rate.text().replace(',', '.'))
44804483
else:
44814484
feed = self.frFeed
44824485
zHeight = self.zMax - (hal.get_value('plasmac.max-offset') * self.unitsPerMm)

share/qtvcp/screens/qtplasmac/versions.html

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ <h2>QtPlasmaC Version History - LinuxCNC 2.9</h2>
2626
</table>
2727
<br>
2828
<!--- ****** ADD NEXT VERSION BELOW THIS LINE ****** --->
29+
<br><b><u>237.308 2024 Feb 28</u></b>
30+
<ul style="margin:0;">
31+
<li>fix matl overlay for locales that use a comma as a decimal</li>
32+
</ul>
33+
2934
<br><b><u>237.307 2024 Feb 25</u></b>
3035
<ul style="margin:0;">
3136
<li>add translation for tool type</li>

0 commit comments

Comments
 (0)