Skip to content

Commit 69d39c6

Browse files
committed
issue #528 - use UTC in DateTimeHandlerTest and ParameterExtractionTest
Now the DateTimeHandler are dependent on the current timezone of the java runtime. On our CI environment, it must be UTC. Now we'll set UTC as the default timezone at the beginning of these tests so they can pass like they used to. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
1 parent 565b595 commit 69d39c6

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

fhir-persistence-jdbc/src/test/java/com/ibm/fhir/persistence/jdbc/test/util/ParameterExtractionTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
import java.time.format.DateTimeFormatterBuilder;
1919
import java.time.temporal.ChronoField;
2020
import java.util.List;
21+
import java.util.TimeZone;
2122

23+
import org.testng.annotations.BeforeClass;
2224
import org.testng.annotations.Test;
2325

2426
import com.ibm.fhir.model.resource.SearchParameter;
@@ -99,6 +101,11 @@ public class ParameterExtractionTest {
99101
private static final SearchParameter stringSearchParam = searchParamBuilder.type(SearchParamType.STRING).build();
100102
private static final SearchParameter tokenSearchParam = searchParamBuilder.type(SearchParamType.TOKEN).build();
101103

104+
@BeforeClass
105+
public void setSystemTimeZone() {
106+
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
107+
}
108+
102109
@Test
103110
public void testBoolean() throws FHIRPersistenceProcessorException {
104111
JDBCParameterBuildingVisitor parameterBuilder = new JDBCParameterBuildingVisitor(tokenSearchParam);

fhir-search/src/test/java/com/ibm/fhir/search/date/DateTimeHandlerTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414
import java.time.Instant;
1515
import java.time.temporal.ChronoField;
1616
import java.time.temporal.TemporalAccessor;
17+
import java.util.TimeZone;
1718

19+
import org.testng.annotations.BeforeClass;
1820
import org.testng.annotations.Test;
1921

2022
import com.ibm.fhir.model.type.DateTime;
@@ -23,6 +25,11 @@
2325

2426
public class DateTimeHandlerTest {
2527

28+
@BeforeClass
29+
public void setSystemTimeZone() {
30+
TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
31+
}
32+
2633
@Test
2734
public void testYearParser() throws FHIRSearchException {
2835
TemporalAccessor acc = DateTimeHandler.parse("2019");

0 commit comments

Comments
 (0)