Skip to content

Commit adc31e3

Browse files
committed
remove the profile for java11
it still builds with OpenJDK 11, it just cross-compiles for java 1.8. i kept the java.version property, so folks can still pass `-Djava.version=11` if they really want to compile for java 11, but since we want to be buildable and runnable on java 8 we won't be using any java 11 source features at this time. also set fail-fast to false so that we get both java 8 and java 11 results each time Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
1 parent 6f70914 commit adc31e3

2 files changed

Lines changed: 3 additions & 9 deletions

File tree

.github/workflows/build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
java: [ 'openjdk8', 'openjdk11' ]
14+
fail-fast: false
1415
steps:
1516
- uses: actions/checkout@v1
1617
- name: Set up OpenJDK
@@ -32,6 +33,7 @@ jobs:
3233
strategy:
3334
matrix:
3435
java: [ 'openjdk8', 'openjdk11' ]
36+
fail-fast: false
3537
steps:
3638
- uses: actions/checkout@v1
3739
- name: Set up OpenJDK
@@ -47,6 +49,7 @@ jobs:
4749
strategy:
4850
matrix:
4951
java: [ 'openjdk8', 'openjdk11' ]
52+
fail-fast: false
5053
steps:
5154
- uses: actions/checkout@v1
5255
- name: Set up OpenJDK

fhir-parent/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -876,14 +876,5 @@
876876
</repository>
877877
</distributionManagement>
878878
</profile>
879-
<profile>
880-
<id>switch-jdk-11</id>
881-
<activation>
882-
<jdk>!1.8</jdk>
883-
</activation>
884-
<properties>
885-
<java.version>11</java.version>
886-
</properties>
887-
</profile>
888879
</profiles>
889880
</project>

0 commit comments

Comments
 (0)