Skip to content

Separation of concerns: Download client adapters should include the logic to poll completed downloads #495

@T4g1

Description

@T4g1

The code from DownloadMonitorService hardcode adapters and pooling logic. Each adapter specific pooling method should be moved to the corresponding IDownloadClientAdapter implementation instead

Note that I'm currently rewritting the handling of adapters as part of #465 and thus will probably replace the hardcoded switch from PollDownloadClientsAsync method there as it allows to query the NET dynamic injection thing to fetch adapter based on an implementation enumeration

Also, the pooling logic might be simplified by using specific adapters's GetItemsAsync (or replacing method GetQueueAsync for which implementation does not seems ready yet) and comparing those to pooled downloads instead of querying them directly from the pooling method

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions