fix logError

Author: xiaoqch

FakePlayerManager.lxl.js

@@ -350,22 +350,30 @@ function trInfo(_key, ..._args) {
     logger.info(Color.transformToConsole(tr(...arguments)));
 }
 function logError(msg, e, player) {
-    let errorMessage = null;
-    let stack = null;
-    if (e instanceof Error) {
-        errorMessage = e.message;
-        stack = e.stack;
-    } else if (typeof (e) == "string") {
-        errorMessage = e;
-    } else {
-        errorMessage = JSON.stringify(e);
-    }
-    if (player) {
-        player.tell(`${Color.RED}${msg}: ${errorMessage}`);
-    }
-    logger.error(`${msg}: ${errorMessage}`);
-    if (stack) {
-        logger.error(stack);
+    try{
+        let errorMessage = null;
+        let stack = null;
+        if (e instanceof Error) {
+            errorMessage = e.message;
+            stack = e.stack;
+        } else if (typeof (e) == "string") {
+            errorMessage = e;
+        } else {
+            errorMessage = JSON.stringify(e);
+        }
+        if (player) {
+            if(typeof player == "string")
+                player = mc.getPlayer(player);
+            if(player)
+                player.tell(`${Color.RED}${msg}: ${errorMessage}`);
+        }
+        logger.error(`${msg}: ${errorMessage}`);
+        if (stack) {
+            logger.error(stack);
+        }
+    }catch(e){
+        logger.error(`[logError] ${e.message}`);
+        logger.error(`[logError] ${e.stack}`);
     }
 }
 

FakePlayerManager/FakePlayerController.js

@@ -896,6 +896,9 @@ class FakePlayerFormHelper {
                 this.tell(this.OPERATIONS.Cancel);
             return;
         }
+        if(!this.manager.ready){
+            throw new Error('FakePlayerManager is not ready');
+        }
         let msg;
         switch (menus[id]) {
             case FORM_MENU.Agent:
@@ -1092,9 +1095,11 @@ class FakePlayerManager {
         });
     }
     sendMenuForm(player) {
-        this.refreshData();
-        let fh = new FakePlayerFormHelper(this, player);
-        fh.sendMenuForm().catch(e => {
+        (async () => {
+            this.refreshData();
+            let fh = new FakePlayerFormHelper(this, player);
+            await fh.sendMenuForm();
+        })().catch(e => {
             logError('sendMenuForm', e, player);
         });
     }
@@ -1723,7 +1728,7 @@ class FakePlayerWebSocketController extends FakePlayerController {
         if (!this.ready) {
             if (!await this.connectWebsocket()) {
                 if (Settings.debugMode) logError("Error in send msg", msg);
-                throw new Error(tr("ws.error.send", { code: this.wsc.errorCode() }));
+                new Error(tr("ws.error.send", { code: this.wsc.errorCode() }));
             }
         }
         return new Promise((resolve, reject) => {