review comments

Author: BRUNER Patrick

src/LogExpert.Core/Classes/Persister/ProjectFileValidator.cs

@@ -146,14 +146,10 @@ private static List<string> FindAlternativePaths (string fileName, string projec
 
                     // Also check subdirectories (one level deep)
                     var subdirs = Directory.GetDirectories(projectDir);
-                    foreach (var subdir in subdirs)
-                    {
-                        var subdirCandidate = Path.Join(subdir, baseName);
-                        if (File.Exists(subdirCandidate))
-                        {
-                            alternatives.Add(subdirCandidate);
-                        }
-                    }
+                    alternatives.AddRange(
+                        subdirs
+                            .Select(subdir => Path.Join(subdir, baseName))
+                            .Where(File.Exists));
                 }
             }
             catch (Exception ex) when (ex is ArgumentException or
@@ -181,10 +177,10 @@ UnauthorizedAccessException or
             }
         }
         catch (Exception ex) when (ex is ArgumentException or
-                                        ArgumentNullException or
-                                        PathTooLongException or
-                                        UnauthorizedAccessException or
-                                        IOException)
+                                         ArgumentNullException or
+                                         PathTooLongException or
+                                         UnauthorizedAccessException or
+                                         IOException)
         {
             // Ignore errors when searching in Documents folder
         }
@@ -203,23 +199,20 @@ UnauthorizedAccessException or
                 var originalDrive = Path.GetPathRoot(fileName)?[0];
                 var pathWithoutDrive = fileName.Length > 3 ? fileName[3..] : string.Empty;
 
-                foreach (var drive in driveLetters)
+                foreach (var drive in driveLetters.Where(drive => drive != originalDrive && !string.IsNullOrEmpty(pathWithoutDrive)))
                 {
-                    if (drive != originalDrive && !string.IsNullOrEmpty(pathWithoutDrive))
+                    var alternatePath = $"{drive}:\\{pathWithoutDrive}";
+                    if (File.Exists(alternatePath) && !alternatives.Contains(alternatePath))
                     {
-                        var alternatePath = $"{drive}:\\{pathWithoutDrive}";
-                        if (File.Exists(alternatePath) && !alternatives.Contains(alternatePath))
-                        {
-                            alternatives.Add(alternatePath);
-                        }
+                        alternatives.Add(alternatePath);
                     }
                 }
             }
             catch (Exception ex) when (ex is ArgumentException or
-                                            ArgumentNullException or
-                                            PathTooLongException or
-                                            UnauthorizedAccessException or
-                                            IOException)
+                                             ArgumentNullException or
+                                             PathTooLongException or
+                                             UnauthorizedAccessException or
+                                             IOException)
             {
                 // Ignore errors when searching on different drives
             }

src/LogExpert.Persister.Tests/ProjectFileValidatorTests.cs

@@ -102,9 +102,8 @@ private void CreatePersistenceFile (string lxpFileName, string logFileName)
     /// </summary>
     private void DeleteLogFiles (params string[] fileNames)
     {
-        foreach (var fileName in fileNames)
+        foreach (var filePath in fileNames.Select(fileName => Path.Join(_testDirectory, fileName)))
         {
-            var filePath = Path.Join(_testDirectory, fileName);
             if (File.Exists(filePath))
             {
                 File.Delete(filePath);

src/LogExpert.UI/Dialogs/MissingFilesDialog.cs

@@ -266,7 +266,6 @@ private void UpdateSummary ()
     /// Opens a file browser dialog for the specified missing file.
     /// </summary>
     /// <param name="fileItem">The file item to browse for</param>
-    [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Intentionally Left Blank")]
     private void BrowseForFile (MissingFileItem fileItem)
     {
         using var openFileDialog = new OpenFileDialog
@@ -287,7 +286,10 @@ private void BrowseForFile (MissingFileItem fileItem)
                 openFileDialog.InitialDirectory = directory;
             }
         }
-        catch
+        catch (Exception ex) when (ex is ArgumentException or
+                                         PathTooLongException or
+                                         NotSupportedException or
+                                         UnauthorizedAccessException)
         {
             // Ignore if path is invalid
         }