code quality fixes

Author: Hirogen

.github/workflows/build_dotnet.yml

@@ -56,12 +56,13 @@ jobs:
           git config user.name "github-actions[bot]"
           git config user.email "github-actions[bot]@users.noreply.github.com"
           git add src/PluginRegistry/PluginHashGenerator.Generated.cs
-          if git diff --staged --quiet; then
-            echo "No changes to commit"
-          else
+          $hasChanges = git diff --staged --quiet; $LASTEXITCODE -ne 0
+          if ($hasChanges) {
             git commit -m "chore: update plugin hashes [skip ci]"
             git push
-          fi
+          } else {
+            Write-Host "No changes to commit"
+          }
 
       - name: Upload artifact
         uses: actions/upload-artifact@v4

src/PluginRegistry/PluginCache.cs

@@ -153,24 +153,11 @@ public void ClearCache ()
     /// <returns>Number of entries removed</returns>
     public int RemoveExpiredEntries ()
     {
-        var removedCount = 0;
-        var keysToRemove = new List<string>();
 
-        foreach (var kvp in _cache)
-        {
-            if (!IsCacheValid(kvp.Value))
-            {
-                keysToRemove.Add(kvp.Key);
-            }
-        }
+        var keysToRemove = _cache.Where(kvp => !IsCacheValid(kvp.Value)).Select(kvp => kvp.Key).ToList();
 
-        foreach (var key in keysToRemove)
-        {
-            if (_cache.TryRemove(key, out _))
-            {
-                removedCount++;
-            }
-        }
+        var removedCount = 0;
+        removedCount = keysToRemove.Select(key => _cache.TryRemove(key, out _)).Count(removed => removed);
 
         if (removedCount > 0)
         {

src/PluginRegistry/PluginManifest.cs

@@ -243,12 +243,9 @@ public bool Validate (out List<string> errors)
         // Validate permissions if present
         if (Permissions != null && Permissions.Count > 0)
         {
-            foreach (var permission in Permissions)
+            foreach (var permission in Permissions.Where(p => !IsValidPermission(p)))
             {
-                if (!IsValidPermission(permission))
-                {
-                    errors.Add($"Invalid permission: {permission}");
-                }
+                errors.Add($"Invalid permission: {permission}");
             }
         }
 

src/PluginRegistry/PluginRegistry.cs

@@ -922,19 +922,16 @@ public void CleanupPlugins ()
         // Call lifecycle Shutdown
         if (_useLifecycleHooks)
         {
-            foreach (var columnizer in RegisteredColumnizers)
+            foreach (var lifecycle in RegisteredColumnizers.OfType<IPluginLifecycle>())
             {
-                if (columnizer is IPluginLifecycle lifecycle)
+                try
                 {
-                    try
-                    {
-                        lifecycle.Shutdown();
-                        _logger.Debug("Called Shutdown on plugin");
-                    }
-                    catch (Exception ex)
-                    {
-                        _logger.Error(ex, "Plugin Shutdown failed");
-                    }
+                    lifecycle.Shutdown();
+                    _logger.Debug("Called Shutdown on plugin");
+                }
+                catch (Exception ex)
+                {
+                    _logger.Error(ex, "Plugin Shutdown failed");
                 }
             }
         }