Remove all UI code from the Core project

Author: Randall Flagg

src/LogExpert.Core/Classes/Filter/Filter.cs

@@ -1,13 +1,8 @@
 using LogExpert.Classes.ILogLineColumnizerCallback;
 using LogExpert.Core.Classes;
 using LogExpert.Core.Classes.Filter;
-
 using NLog;
 
-using System;
-using System.Collections.Generic;
-using System.Windows.Forms;
-
 namespace LogExpert.Classes.Filter
 {
     internal delegate void FilterFx(FilterParams filterParams, List<int> filterResultLines, List<int> lastFilterResultLines, List<int> filterHitList);

src/LogExpert.Core/Classes/Util.cs

@@ -1,5 +1,4 @@
 using LogExpert.Core.Classes.Filter;
-
 using System.Diagnostics;
 using System.Drawing;
 using System.Runtime.Versioning;
@@ -402,59 +401,6 @@ public static void AssertTrue(bool condition, string msg)
             }
         }
 
-        [SupportedOSPlatform("windows")]
-        public string GetWordFromPos(int xPos, string text, Graphics g, Font font)
-        {
-            string[] words = text.Split([' ', '.', ':', ';']);
-
-            int index = 0;
-
-            List<CharacterRange> crList = [];
-
-            for (int i = 0; i < words.Length; ++i)
-            {
-                crList.Add(new CharacterRange(index, words[i].Length));
-                index += words[i].Length;
-            }
-
-            CharacterRange[] crArray = [.. crList];
-
-            StringFormat stringFormat = new(StringFormat.GenericTypographic)
-            {
-                Trimming = StringTrimming.None,
-                FormatFlags = StringFormatFlags.NoClip
-            };
-
-            stringFormat.SetMeasurableCharacterRanges(crArray);
-
-            RectangleF rect = new(0, 0, 3000, 20);
-            Region[] stringRegions = g.MeasureCharacterRanges(text, font, rect, stringFormat);
-
-            bool found = false;
-
-            int y = 0;
-
-            foreach (Region regio in stringRegions)
-            {
-                if (regio.IsVisible(xPos, 3, g))
-                {
-                    found = true;
-                    break;
-                }
-
-                y++;
-            }
-
-            if (found)
-            {
-                return words[y];
-            }
-            else
-            {
-                return null;
-            }
-        }
-
         #endregion
 
         #region Private Methods

src/LogExpert.Core/Entities/FileViewContext.cs

@@ -2,7 +2,7 @@
 
 namespace LogExpert.Core.Entities
 {
-    public class FileViewContext(ILogPaintContext logPaintContext, ILogView logView)
+    public class FileViewContext(ILogPaintContext logPaintContext, ILogView logView) : IFileViewContext, ILogPaintContext
     {
         #region Properties
 

src/LogExpert.Core/Interface/IFileViewContext.cs

@@ -0,0 +1,10 @@
+using LogExpert.Core.Entities;
+
+namespace LogExpert.Core.Interface
+{
+    public interface IFileViewContext
+    {
+        ILogView LogView { get; }
+        ILogPaintContext LogPaintContext { get; }
+    }
+}

src/LogExpert.Core/Interface/ILogPaintContext.cs

@@ -1,36 +1,6 @@
-using LogExpert.Core.Classes.Highlight;
-using LogExpert.Core.Entities;
-
-using System.Drawing;
-
-namespace LogExpert.Core.Interface
+namespace LogExpert.Core.Interface
 {
-    /// <summary>
-    /// Declares methods that are needed for drawing log lines. Used by PaintHelper.
-    /// </summary>
     public interface ILogPaintContext
     {
-        #region Properties
-
-        Font MonospacedFont { get; } // Font font = new Font("Courier New", this.Preferences.fontSize, FontStyle.Bold);
-        Font NormalFont { get; }
-        Font BoldFont { get; }
-        Color BookmarkColor { get; }
-
-        #endregion
-
-        #region Public methods
-
-        ILogLine GetLogLine(int lineNum);
-
-        IColumn GetCellValue(int rowIndex, int columnIndex);
-
-        Bookmark GetBookmarkForLine(int lineNum);
-
-        HighlightEntry FindHighlightEntry(ITextValue line, bool noWordMatches);
-
-        IList<HilightMatchEntry> FindHighlightMatches(ITextValue line);
-
-        #endregion
     }
 }

src/LogExpert.Core/Interface/ISharedToolWindow.cs

@@ -1,5 +1,4 @@
 using LogExpert.Core.Config;
-using LogExpert.Core.Entities;
 
 namespace LogExpert.Core.Interface
 {
@@ -16,7 +15,7 @@ public interface ISharedToolWindow
         /// Called when a file becomes the active file (e.g. when user selects a tab).
         /// </summary>
         /// <param name="ctx"></param>
-        void SetCurrentFile(FileViewContext ctx);
+        void SetCurrentFile(IFileViewContext ctx);
 
         /// <summary>
         /// Called whenever the current file has been changed.

src/LogExpert.Core/LogExpert.Core.csproj

@@ -8,6 +8,8 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <SignAssembly>True</SignAssembly>
     <AssemblyOriginatorKeyFile>..\Solution Items\Key.snk</AssemblyOriginatorKeyFile>
+    <PublishAot>false</PublishAot>
+    <NoWarn>CS8625;CS8603;CS8618;CS8600;CS8603;CS8602;CS8604;CS8622;CS8601;</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
@@ -21,7 +23,6 @@
   <ItemGroup>
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="NLog" />
-    <PackageReference Include="System.Drawing.Common" />
   </ItemGroup>
 
   <ItemGroup>

src/LogExpert.UI/Controls/LogWindow/LogWindow.cs

@@ -14,14 +14,15 @@
 using LogExpert.UI.Controls.LogTabWindow;
 using LogExpert.UI.Dialogs;
 using LogExpert.UI.Extensions.Forms;
+using LogExpert.UI.Interface;
 using NLog;
 using WeifenLuo.WinFormsUI.Docking;
 //using static LogExpert.PluginRegistry.PluginRegistry; //TODO: Adjust the instance name so using static can be used.
 
 namespace LogExpert.UI.Controls.LogWindow
 {
     //TODO: Implemented 4 interfaces explicitly. Find them by searcginh: ILogWindow.<method name>
-    internal partial class LogWindow : DockContent, ILogPaintContext, ILogView, ILogWindow
+    internal partial class LogWindow : DockContent, ILogPaintContextUI, ILogView, ILogWindow
     {
         #region Fields
 

src/LogExpert.UI/Dialogs/BookmarkWindow.cs

@@ -4,14 +4,8 @@
 using LogExpert.Core.Interface;
 using LogExpert.UI.Entities;
 using LogExpert.UI.Extensions.Forms;
-
+using LogExpert.UI.Interface;
 using NLog;
-
-using System;
-using System.Collections.Generic;
-using System.Drawing;
-using System.Windows.Forms;
-
 using WeifenLuo.WinFormsUI.Docking;
 
 namespace LogExpert.Dialogs;
@@ -25,7 +19,7 @@ public partial class BookmarkWindow : DockContent, ISharedToolWindow, IBookmarkV
     private readonly object paintLock = new();
 
     private IBookmarkData bookmarkData;
-    private ILogPaintContext logPaintContext;
+    private ILogPaintContextUI logPaintContext;
     private ILogView logView;
 
     #endregion
@@ -218,15 +212,15 @@ public void PreferencesChanged(Preferences newPreferences, bool isLoadTime, Sett
         PreferencesChanged(newPreferences, isLoadTime, flags, null);
     }
 
-    public void SetCurrentFile(FileViewContext ctx)
+    public void SetCurrentFile(IFileViewContext ctx)
     {
         if (ctx != null)
         {
             _logger.Debug("Current file changed to {0}", ctx.LogView.FileName);
             lock (paintLock)
             {
                 logView = ctx.LogView;
-                logPaintContext = ctx.LogPaintContext;
+                logPaintContext = (ILogPaintContextUI)ctx.LogPaintContext;
             }
 
             SetColumnizer(ctx.LogView.CurrentColumnizer);

src/LogExpert.UI/Entities/PaintHelper.cs

@@ -4,6 +4,7 @@
 using LogExpert.Core.Interface;
 using LogExpert.Dialogs;
 using LogExpert.UI.Controls;
+using LogExpert.UI.Interface;
 using NLog;
 
 namespace LogExpert.UI.Entities
@@ -29,7 +30,7 @@ internal static class PaintHelper
 
         #region Public methods
 
-        public static void CellPainting(ILogPaintContext logPaintCtx, BufferedDataGridView gridView, int rowIndex,
+        public static void CellPainting(ILogPaintContextUI logPaintCtx, BufferedDataGridView gridView, int rowIndex,
             DataGridViewCellPaintingEventArgs e)
         {
             if (rowIndex < 0 || e.ColumnIndex < 0)
@@ -293,12 +294,12 @@ public static Rectangle BorderWidths(DataGridViewAdvancedBorderStyle advancedBor
 
         #region Private Methods
 
-        private static void PaintCell(ILogPaintContext logPaintCtx, DataGridViewCellPaintingEventArgs e, BufferedDataGridView gridView, bool noBackgroundFill, HighlightEntry groundEntry)
+        private static void PaintCell(ILogPaintContextUI logPaintCtx, DataGridViewCellPaintingEventArgs e, BufferedDataGridView gridView, bool noBackgroundFill, HighlightEntry groundEntry)
         {
             PaintHighlightedCell(logPaintCtx, e, gridView, noBackgroundFill, groundEntry);
         }
 
-        private static void PaintHighlightedCell(ILogPaintContext logPaintCtx, DataGridViewCellPaintingEventArgs e, BufferedDataGridView gridView, bool noBackgroundFill, HighlightEntry groundEntry)
+        private static void PaintHighlightedCell(ILogPaintContextUI logPaintCtx, DataGridViewCellPaintingEventArgs e, BufferedDataGridView gridView, bool noBackgroundFill, HighlightEntry groundEntry)
         {
             object value = e.Value ?? string.Empty;