review comments

Author: Hirogen

src/ColumnizerLib/ILogLine.cs

@@ -39,6 +39,7 @@ public interface ILogLine : ITextValue
 /// </para>
 /// </remarks>
 public readonly struct LogLine (string fullLine, int lineNumber) : ILogLine
+{
     public string FullLine { get; } = fullLine;
 
     public int LineNumber { get; } = lineNumber;

src/LogExpert.Benchmarks/StreamReaderBenchmarks.cs

@@ -183,6 +183,6 @@ public static class Program
 {
     public static void Main (string[] args)
     {
-        var summary = BenchmarkRunner.Run<StreamReaderBenchmarks>();
+        _ = BenchmarkRunner.Run<StreamReaderBenchmarks>();
     }
 }

src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderPipeline.cs

@@ -157,6 +157,7 @@ protected override void Dispose (bool disposing)
                     {
                         segment.Dispose();
                     }
+
                     _lineQueue.Dispose();
                 }
 
@@ -200,6 +201,13 @@ private void RestartPipeline (long newPosition)
         }
     }
 
+    /// <summary>
+    /// Cancels the current pipeline operation and releases associated resources. This method should be called while
+    /// holding the appropriate lock to ensure thread safety.
+    /// </summary>
+    /// <remarks>This method cancels any ongoing producer task, marks the internal queue as complete to
+    /// unblock waiting consumers, and disposes of pipeline resources. It is intended for internal use and must be
+    /// invoked only when the pipeline is in a valid state for cancellation.</remarks>
     private void CancelPipelineLocked ()
     {
         if (_cts == null)
@@ -226,7 +234,7 @@ private void CancelPipelineLocked ()
         }
         finally
         {
-            _cts?.Dispose();
+            _cts.Dispose();
             _cts = null;
         }
 
@@ -444,15 +452,12 @@ private void EnqueueLine (LineSegment segment)
                 }
 
                 // If still no space, force process current content as truncated line
-                if (charsInBuffer >= _charBufferSize - 100)
+                if (charsInBuffer >= _charBufferSize - 100 && charsInBuffer > 0)
                 {
-                    if (charsInBuffer > 0)
-                    {
-                        var segment = CreateSegment(charBuffer, 0, charsInBuffer, 0, byteOffset);
-                        byteOffset += segment.ByteLength;
-                        EnqueueLine(segment);
-                        charsInBuffer = 0;
-                    }
+                    var segment = CreateSegment(charBuffer, 0, charsInBuffer, 0, byteOffset);
+                    byteOffset += segment.ByteLength;
+                    EnqueueLine(segment);
+                    charsInBuffer = 0;
                 }
 
                 charsAvailable = _charBufferSize - charsInBuffer;