update

Author: Hirogen

src/LogExpert.Core/Classes/Log/PositionAwareStreamReaderPipeline.cs

@@ -8,7 +8,7 @@
 
 namespace LogExpert.Core.Classes.Log;
 
-public class PositionAwareStreamReaderPipeline : LogStreamReaderBase, ILogStreamReaderSpan
+public class PositionAwareStreamReaderPipeline : LogStreamReaderBase, ILogStreamReaderMemory
 {
     private const int DEFAULT_BYTE_BUFFER_SIZE = 64 * 1024; // 64 KB
     private const int MINIMUM_READ_AHEAD_SIZE = 4 * 1024; // 4 KB
@@ -416,7 +416,8 @@ private void EnqueueLine (LineSegment segment)
         var remaining = localCharsInBuffer - searchIndex;
         if (remaining > 0 && searchIndex > 0)
         {
-            Array.Copy(charBuffer, searchIndex, charBuffer, 0, remaining);
+            charBuffer.AsSpan(searchIndex, remaining).CopyTo(charBuffer.AsSpan(0, remaining));
+            //Array.Copy(charBuffer, searchIndex, charBuffer, 0, remaining);
         }
 
         return (remaining, localByteOffset);
@@ -446,7 +447,8 @@ private void EnqueueLine (LineSegment segment)
                         var remaining = charsInBuffer - searchIndex;
                         if (remaining > 0 && searchIndex > 0)
                         {
-                            Array.Copy(charBuffer, searchIndex, charBuffer, 0, remaining);
+                            charBuffer.AsSpan(searchIndex, remaining).CopyTo(charBuffer.AsSpan(0, remaining));
+                            //Array.Copy(charBuffer, searchIndex, charBuffer, 0, remaining);
                         }
 
                         charsInBuffer = remaining;
@@ -580,7 +582,8 @@ private LineSegment CreateSegment (
         // Copy line content (excluding newline)
         if (logicalLength > 0)
         {
-            Array.Copy(source, start, buffer, 0, logicalLength);
+            source.AsSpan(start, logicalLength).CopyTo(buffer.AsSpan(0, logicalLength));
+            //Array.Copy(source, start, buffer, 0, logicalLength);
         }
 
         return new LineSegment(buffer, logicalLength, byteOffset, byteLength, truncated, false);

src/LogExpert.Core/Interface/ILogStreamReaderMemory.cs

@@ -0,0 +1,34 @@
+namespace LogExpert.Core.Interface;
+
+public interface ILogStreamReaderMemory : ILogStreamReader
+{
+
+    /// <summary>
+    /// Attempts to read the next line from the stream.
+    /// </summary>
+    /// <param name="lineSpan">
+    /// When this method returns <c>true</c>, contains a <see cref="ReadOnlyMemory{Char}"/> representing the next line read from the stream.
+    /// The memory is only valid until the next call to <see cref="TryReadLine"/> or until <see cref="ReturnMemory"/> is called.
+    /// </param>
+    /// <returns>
+    /// <c>true</c> if a line was successfully read; <c>false</c> if the end of the stream has been reached or no more lines are available.
+    /// </returns>
+    /// <remarks>
+    /// The returned memory is only valid until the next call to <see cref="TryReadLine"/> or until <see cref="ReturnMemory"/> is called.
+    /// This method is not guaranteed to be thread-safe; concurrent access should be synchronized externally.
+    /// </remarks>
+    bool TryReadLine (out ReadOnlyMemory<char> lineSpan);
+
+    /// <summary>
+    /// Returns the memory buffer previously obtained from <see cref="TryReadLine"/> to the underlying pool or resource manager.
+    /// </summary>
+    /// <param name="memory">
+    /// The <see cref="ReadOnlyMemory{Char}"/> instance previously obtained from <see cref="TryReadLine"/>.
+    /// </param>
+    /// <remarks>
+    /// Call this method when you are done processing the memory returned by <see cref="TryReadLine"/> to avoid memory leaks or resource retention.
+    /// Failing to call this method may result in increased memory usage.
+    /// It is safe to call this method multiple times for the same memory, but only the first call will have an effect.
+    /// </remarks>
+    void ReturnMemory (ReadOnlyMemory<char> memory);
+}

src/LogExpert.Core/Interface/ILogStreamReaderSpan.cs

@@ -6,8 +6,8 @@ public interface ILogStreamReaderSpan : ILogStreamReader
     /// <summary>
     /// Attempts to read the next line from the stream.
     /// </summary>
-    /// <param name="lineMemory">
-    /// When this method returns <c>true</c>, contains a <see cref="ReadOnlyMemory{Char}"/> representing the next line read from the stream.
+    /// <param name="lineSpan">
+    /// When this method returns <c>true</c>, contains a <see cref="ReadOnlySpan{Char}"/> representing the next line read from the stream.
     /// The memory is only valid until the next call to <see cref="TryReadLine"/> or until <see cref="ReturnMemory"/> is called.
     /// </param>
     /// <returns>
@@ -17,18 +17,18 @@ public interface ILogStreamReaderSpan : ILogStreamReader
     /// The returned memory is only valid until the next call to <see cref="TryReadLine"/> or until <see cref="ReturnMemory"/> is called.
     /// This method is not guaranteed to be thread-safe; concurrent access should be synchronized externally.
     /// </remarks>
-    bool TryReadLine (out ReadOnlyMemory<char> lineMemory);
+    bool TryReadLine (out ReadOnlySpan<char> lineSpan);
 
     /// <summary>
     /// Returns the memory buffer previously obtained from <see cref="TryReadLine"/> to the underlying pool or resource manager.
     /// </summary>
     /// <param name="memory">
-    /// The <see cref="ReadOnlyMemory{Char}"/> instance previously obtained from <see cref="TryReadLine"/>.
+    /// The <see cref="ReadOnlySpan{Char}"/> instance previously obtained from <see cref="TryReadLine"/>.
     /// </param>
     /// <remarks>
     /// Call this method when you are done processing the memory returned by <see cref="TryReadLine"/> to avoid memory leaks or resource retention.
     /// Failing to call this method may result in increased memory usage.
     /// It is safe to call this method multiple times for the same memory, but only the first call will have an effect.
     /// </remarks>
-    void ReturnMemory (ReadOnlyMemory<char> memory);
+    void ReturnMemory (ReadOnlySpan<char> memory);
 }