Merge pull request #322 from Hirogen/issue321

Issue321: Highlights should be there separated .json settings file

Author: Hirogen

src/LogExpert.Tests/JSONSaveTest.cs

@@ -1,6 +1,9 @@
 using LogExpert.Config;
+
 using Newtonsoft.Json;
+
 using NUnit.Framework;
+
 using System.IO;
 
 namespace LogExpert.Tests
@@ -17,14 +20,14 @@ public void SaveOptionsAsJSON()
             string settingsFile = configDir + "\\settings.json";
 
             Settings settings = null;
-            
+
             Assert.DoesNotThrow(CastSettings);
             Assert.That(settings, Is.Not.Null);
             Assert.That(settings.alwaysOnTop, Is.True);
 
             ConfigManager.Settings.alwaysOnTop = false;
             ConfigManager.Save(SettingsFlags.All);
-            
+
             settings = null;
             Assert.DoesNotThrow(CastSettings);
 

src/LogExpert/Classes/CmdLine.cs

@@ -3,7 +3,7 @@
 
 /*
  * Taken from https://cmdline.codeplex.com/
- * 
+ *
  */
 
 namespace LogExpert.Classes
@@ -15,23 +15,19 @@ public class CmdLineException : Exception
     {
         #region cTor
 
-        public CmdLineException(string parameter, string message)
-            :
-            base(string.Format("Syntax error of parameter -{0}: {1}", parameter, message))
+        public CmdLineException(string parameter, string message) : base($"Syntax error of parameter -{parameter}: {message}")
         {
         }
 
-        public CmdLineException(string message)
-            :
-            base(message)
+        public CmdLineException(string message) : base(message)
         {
         }
 
         #endregion
     }
 
     /// <summary>
-    /// Represents a command line parameter. 
+    /// Represents a command line parameter.
     /// Parameters are words in the command line beginning with a hyphen (-).
     /// The value of the parameter is the next word in
     /// </summary>
@@ -103,7 +99,7 @@ public virtual void SetValue(string value)
     }
 
     /// <summary>
-    /// Represents an integer command line parameter. 
+    /// Represents an integer command line parameter.
     /// </summary>
     public class CmdLineInt : CmdLineParameter
     {
@@ -162,22 +158,25 @@ public CmdLineInt(string name, bool required, string helpMessage, int min, int m
         public override void SetValue(string value)
         {
             base.SetValue(value);
-            int i = 0;
+            int i;
+
             try
             {
                 i = Convert.ToInt32(value);
             }
             catch (Exception)
             {
-                throw new CmdLineException(base.Name, "Value is not an integer.");
+                throw new CmdLineException(Name, "Value is not an integer.");
             }
+
             if (i < _min)
             {
-                throw new CmdLineException(base.Name, string.Format("Value must be greather or equal to {0}.", _min));
+                throw new CmdLineException(Name, $"Value must be greather or equal to {_min}.");
             }
+
             if (i > _max)
             {
-                throw new CmdLineException(base.Name, string.Format("Value must be less or equal to {0}.", _max));
+                throw new CmdLineException(Name, $"Value must be less or equal to {_max}.");
             }
             Value = i;
         }
@@ -253,11 +252,11 @@ public CmdLineParameter this[string name]
         {
             get
             {
-                if (!parameters.ContainsKey(name))
+                if (!parameters.TryGetValue(name, out CmdLineParameter value))
                 {
                     throw new CmdLineException(name, "Not a registered parameter.");
                 }
-                return parameters[name];
+                return value;
             }
         }
 
@@ -307,8 +306,8 @@ public string[] Parse(string[] args)
                 if (args[i].Length > 1 && args[i][0] == '-')
                 {
                     // The current string is a parameter name
-                    string key = args[i].Substring(1, args[i].Length - 1).ToLower();
-                    string value = "";
+                    string key = args[i][1..].ToLower();
+                    string value = string.Empty;
                     i++;
                     if (i < args.Length)
                     {
@@ -323,17 +322,17 @@ public string[] Parse(string[] args)
                             i++;
                         }
                     }
-                    if (!parameters.ContainsKey(key))
+                    if (!parameters.TryGetValue(key, out CmdLineParameter cmdLineParameter))
                     {
                         throw new CmdLineException(key, "Parameter is not allowed.");
                     }
 
-                    if (parameters[key].Exists)
+                    if (cmdLineParameter.Exists)
                     {
                         throw new CmdLineException(key, "Parameter is specified more than once.");
                     }
 
-                    parameters[key].SetValue(value);
+                    cmdLineParameter.SetValue(value);
                 }
                 else
                 {
@@ -343,7 +342,7 @@ public string[] Parse(string[] args)
             }
 
 
-            // Check that required parameters are present in the command line. 
+            // Check that required parameters are present in the command line.
             foreach (string key in parameters.Keys)
             {
                 if (parameters[key].Required && !parameters[key].Exists)
@@ -394,7 +393,7 @@ public class ConsoleCmdLine : CmdLine
 
         public ConsoleCmdLine()
         {
-            base.RegisterParameter(new CmdLineString("help", false, "Prints the help screen."));
+            RegisterParameter(new CmdLineString("help", false, "Prints the help screen."));
         }
 
         #endregion
@@ -404,7 +403,7 @@ public ConsoleCmdLine()
         public new string[] Parse(string[] args)
         {
             string[] ret = null;
-            string error = "";
+            string error = string.Empty;
             try
             {
                 ret = base.Parse(args);
@@ -418,15 +417,15 @@ public ConsoleCmdLine()
             {
                 //foreach(string s in base.HelpScreen().Split('\n'))
                 //    Console.WriteLine(s);
-                Console.WriteLine(base.HelpScreen());
-                System.Environment.Exit(0);
+                Console.WriteLine(HelpScreen());
+                Environment.Exit(0);
             }
 
             if (error != "")
             {
                 Console.WriteLine(error);
                 Console.WriteLine("Use -help for more information.");
-                System.Environment.Exit(1);
+                Environment.Exit(1);
             }
             return ret;
         }

src/LogExpert/Classes/Columnizer/ColumnizerPicker.cs

@@ -48,7 +48,7 @@ public static ILogLineColumnizer CloneColumnizer(ILogLineColumnizer columnizer)
                 object o = cti.Invoke(new object[] { });
                 if (o is IColumnizerConfigurator configurator)
                 {
-                    configurator.LoadConfig(ConfigManager.Settings.preferences.PortableMode ? ConfigManager.PortableModeDir : ConfigManager.ConfigDir);
+                    configurator.LoadConfig(ConfigManager.Settings.Preferences.PortableMode ? ConfigManager.PortableModeDir : ConfigManager.ConfigDir);
                 }
                 return (ILogLineColumnizer)o;
             }