unit tests update

Author: BRUNER Patrick

src/LogExpert.Core/Config/Preferences.cs

@@ -26,11 +26,11 @@ public class Preferences
     /// Will be removed in a future version once migration period is complete.
     /// </summary>
     [Obsolete("This property exists only for backward compatibility with old settings files. Use HighlightGroupList instead.")]
-    [Newtonsoft.Json.JsonProperty("hilightGroupList")]
-    [System.Text.Json.Serialization.JsonPropertyName("hilightGroupList")]
+    [Newtonsoft.Json.JsonProperty("hilightGroupList", DefaultValueHandling = Newtonsoft.Json.DefaultValueHandling.Ignore, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+    [System.Text.Json.Serialization.JsonIgnore]
     public List<HighlightGroup> HilightGroupList
     {
-        get => HighlightGroupList;
+        get => null; // Always return null so Newtonsoft.Json won't serialize this property
         set => HighlightGroupList = value ?? [];
     }
 

src/LogExpert.Core/Config/Settings.cs

@@ -42,9 +42,8 @@ public class Settings
     /// Will be removed in a future version once migration period is complete.
     /// </summary>
     [Obsolete("This property exists only for backward compatibility with old settings files. Data is stored in Preferences.HighlightGroupList.")]
-    [Newtonsoft.Json.JsonProperty("hilightEntryList")]
-    [System.Text.Json.Serialization.JsonPropertyName("hilightEntryList")]
-    [System.Text.Json.Serialization.JsonIgnore(Condition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingDefault)]
+    [Newtonsoft.Json.JsonProperty("hilightEntryList", DefaultValueHandling = Newtonsoft.Json.DefaultValueHandling.Ignore, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+    [System.Text.Json.Serialization.JsonIgnore]
     public List<HighlightEntry> HilightEntryList
     {
         get => null; // Never serialize this
@@ -61,9 +60,8 @@ public List<HighlightEntry> HilightEntryList
     /// Will be removed in a future version once migration period is complete.
     /// </summary>
     [Obsolete("This property exists only for backward compatibility with old settings files. Data is stored in Preferences.HighlightGroupList.")]
-    [Newtonsoft.Json.JsonProperty("hilightGroupList")]
-    [System.Text.Json.Serialization.JsonPropertyName("hilightGroupList")]
-    [System.Text.Json.Serialization.JsonIgnore(Condition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingDefault)]
+    [Newtonsoft.Json.JsonProperty("hilightGroupList", DefaultValueHandling = Newtonsoft.Json.DefaultValueHandling.Ignore, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+    [System.Text.Json.Serialization.JsonIgnore]
     public List<HighlightGroup> HilightGroupList
     {
         get => null; // Never serialize this

src/LogExpert.Core/Entities/HighlightGroup.cs

@@ -26,11 +26,11 @@ public class HighlightGroup : ICloneable
     /// Will be removed in a future version once migration period is complete.
     /// </summary>
     [Obsolete("This property exists only for backward compatibility with old settings files. Use HighlightEntryList instead.")]
-    [Newtonsoft.Json.JsonProperty("hilightEntryList")]
-    [System.Text.Json.Serialization.JsonPropertyName("hilightEntryList")]
+    [Newtonsoft.Json.JsonProperty("hilightEntryList", DefaultValueHandling = Newtonsoft.Json.DefaultValueHandling.Ignore, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+    [System.Text.Json.Serialization.JsonIgnore]
     public List<HighlightEntry> HilightEntryList
     {
-        get => HighlightEntryList;
+        get => null; // Always return null so Newtonsoft.Json won't serialize this property
         set => HighlightEntryList = value ?? [];
     }
 

src/LogExpert.Tests/ConfigManagerTest.cs

@@ -975,4 +975,105 @@ public void BackupFile_AlwaysValid_WhenExists ()
     }
 
     #endregion
+
+    #region Backward Compatibility Tests
+
+    [Test]
+    [Category("BackwardCompatibility")]
+    [Description("LoadOrCreateNew should successfully load old JSON with 'hilightGroupList' typo")]
+    public void LoadOrCreateNew_LegacyHilightGroupList_LoadsSuccessfully ()
+    {
+        // Arrange - Create JSON with old "hilightGroupList" property name (with typo)
+        string legacyJson = @"{
+  ""Preferences"": {
+    ""hilightGroupList"": [
+      {
+        ""GroupName"": ""LegacyGroup"",
+        ""hilightEntryList"": []
+      }
+    ],
+    ""FontName"": ""Courier New"",
+    ""FontSize"": 9
+  },
+  ""FilterList"": [],
+  ""SearchHistoryList"": []
+}";
+        File.WriteAllText(_testSettingsFile.FullName, legacyJson);
+
+        // Act
+        LoadResult loadResult = InvokePrivateInstanceMethod<LoadResult>("LoadOrCreateNew", _testSettingsFile);
+
+        // Assert
+        Assert.That(loadResult, Is.Not.Null);
+        Assert.That(loadResult.Settings, Is.Not.Null);
+        Assert.That(loadResult.Settings.Preferences.HighlightGroupList.Count, Is.EqualTo(1), "Should load legacy 'hilightGroupList' into HighlightGroupList");
+        Assert.That(loadResult.Settings.Preferences.HighlightGroupList[0].GroupName, Is.EqualTo("LegacyGroup"));
+    }
+
+    [Test]
+    [Category("BackwardCompatibility")]
+    [Description("SaveAsJSON should not write the obsolete 'hilightGroupList' property")]
+    public void SaveAsJSON_DoesNotWriteLegacyProperty ()
+    {
+        // Arrange
+        Settings settings = CreateTestSettings();
+        settings.Preferences.HighlightGroupList.Add(new HighlightGroup { GroupName = "TestGroup" });
+
+        // Act
+        InvokePrivateInstanceMethod("SaveAsJSON", _testSettingsFile, settings);
+
+        // Assert
+        string json = File.ReadAllText(_testSettingsFile.FullName);
+
+        // Should contain the new property name
+        Assert.That(json, Does.Contain("HighlightGroupList"),
+            "Should write 'HighlightGroupList' property");
+
+        // Should NOT contain the legacy property name
+        Assert.That(json, Does.Not.Contain("hilightGroupList"),
+            "Should NOT write obsolete 'hilightGroupList' property");
+
+        // Verify the content is correct
+        Assert.That(json, Does.Contain("TestGroup"));
+    }
+
+    [Test]
+    [Category("BackwardCompatibility")]
+    [Description("Old JSON with both properties should not create duplicates")]
+    public void LoadOrCreateNew_BothPropertiesInJSON_NoDuplicates ()
+    {
+        // Arrange - Create JSON with BOTH property names (simulating a corrupted file)
+        string jsonWithBoth = @"{
+  ""Preferences"": {
+    ""HighlightGroupList"": [
+      {
+        ""GroupName"": ""Group1"",
+        ""HighlightEntryList"": []
+      }
+    ],
+    ""hilightGroupList"": [
+      {
+        ""GroupName"": ""Group1"",
+        ""hilightEntryList"": []
+      }
+    ],
+    ""FontName"": ""Courier New"",
+    ""FontSize"": 9
+  },
+  ""FilterList"": [],
+  ""SearchHistoryList"": []
+}";
+        File.WriteAllText(_testSettingsFile.FullName, jsonWithBoth);
+
+        // Act
+        LoadResult loadResult = InvokePrivateInstanceMethod<LoadResult>("LoadOrCreateNew", _testSettingsFile);
+
+        // Assert
+        Assert.That(loadResult, Is.Not.Null);
+        Assert.That(loadResult.Settings, Is.Not.Null);
+        Assert.That(loadResult.Settings.Preferences.HighlightGroupList.Count, Is.EqualTo(1), "Should have exactly 1 group, not duplicates");
+        Assert.That(loadResult.Settings.Preferences.HighlightGroupList[0].GroupName, Is.EqualTo("Group1"));
+    }
+
+    #endregion
 }